Add AdSpeed ad server to amp-ad#7219
Conversation
|
/to @lannka |
|
|
||
| adspeed: { | ||
| preconnect: 'https://g.adspeed.net', | ||
| }, |
There was a problem hiding this comment.
could you also implement the render-start and no-content API?
…kend. Tested both scenarios.
|
Hello, I've just updated our backend JS code to call the API renderStart() and noContentAvailable() when suitable and I modified ads/_config.js. However, Travis CI build failed (error below), which I don't think is because of our code, looks like a config thing. Please check and restart build if it's the case. Thanks "The command "node build-system/pr-check.js" exited with 1." |
|
Hello. Can someone help restart Travis build? Thanks! |
|
Restarted. |
|
It failed very early again at: "pr-check.js - any update to package.json or yarn.lock must include the other file. Please update through yarn." Anyone knows why? I re-ran these local checks on my machine without any issue:
Thanks for your help |
|
/cc @erwinmombay |
|
Hello, Any help with the build config/troubleshooting/result? Or should I close this PR and restart using the latest amphtml revision? Thanks! |
|
Try rebasing against current master? Assuming you called $ git pull --rebase upstream/master |
|
Thanks Justin! That (updating/syncing the fork) definitely helped and all checks have passed now. Please review. |
|
Thanks!! |
* Add AdSpeed ad server to amp-ad * Change zid/oid to zone/client since oid is conflicting * Implemented renderStart() and noContentAvailable() API in AdSpeed backend. Tested both scenarios.
Hello,
I've followed the guidelines and examples to add support for AdSpeed ad server into amp-ad.
Please review and let me know. Thanks!