Add viewer integration script based on amp_js_v#7703
Merged
muxin merged 2 commits intoampproject:masterfrom Feb 21, 2017
Merged
Add viewer integration script based on amp_js_v#7703muxin merged 2 commits intoampproject:masterfrom
muxin merged 2 commits intoampproject:masterfrom
Conversation
526cc75 to
4ca0e1f
Compare
lannka
approved these changes
Feb 21, 2017
| * @param {string} file | ||
| */ | ||
| function addViewerIntegrationScript(ampJsVersion, file) { | ||
| ampJsVersion = parseFloat(ampJsVersion); |
Contributor
There was a problem hiding this comment.
you can flip if-else and return early
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7461
/cc @chenshay