Add support for SlimCut Media ads in amp-ad#7265
Conversation
|
/to @lannka |
lannka
left a comment
There was a problem hiding this comment.
The example does not load an ad locally. could you check?
|
Example was limited to the heroku test site, sorry for that. We authorize domains localhost and ampscm.herokuapp.com. Thanks |
|
@m1ck43l the example works now. But I see a noticeable blank time between the loading indicator and the ad display. Could you confirm you're calling render-start API at the right time? |
|
@lannka We plan to add a loading screen to avoid the blank time. Do you need it to be implemented right for the PR? Thanks |
|
@lannka We've added the loading screen. The white screen will disappear once we have the ad. Thanks |
|
@m1ck43l sorry for the late reply. AMP runtime already provided a loading indicator. Are you able to call render-start at the time you hide your loading screen? If not, I'd prefer no 2nd loading indicator. |
|
@lannka We've removed the second loading indicator. Should be good now. |
Hello,
I've followed the guidelines and examples to add support for SlimCut Media ads into amp-ad.
Please review this pull request, thanks!
Implements #7254