Update Getting Started guides with release info by mrjoro · Pull Request #7681 · ampproject/amphtml

mrjoro · 2017-02-20T18:59:00Z

Added a section to the E2E and Quick Start Getting Started guides on how a changes gets to production and how the contributor can track where it is/test on Dev Channel.

cc @cramforce @bpaduch

cramforce · 2017-02-21T04:35:13Z

contributing/getting-started-quick.md

+
+# See your changes in production
+
+* Barring any issues releases are cut Thursday, pushed to Dev Channel immediately, pushed to 1% on Monday and pushed to all of prod on Thursday.


1% of AMP pages

…and pushed to all pages…

cramforce · 2017-02-21T04:35:44Z

contributing/getting-started-e2e.md

+
+If your change affected internal documentation, tests, the build process, etc. you can generally see your changes right after they're merged.  If your change was to the code that runs on AMP pages across the web you'll have to wait for the change to be included in a release.
+
+In general we cut a release of amphtml on Thursdays during working hours (Pacific time) and push it to the AMP Dev Channel that day.  After verifying there are no issues, we start rolling that build out the following Monday and complete the push that Thursday.


Maybe add: This is when all users of AMP will use your new code!

cramforce · 2017-02-21T17:10:17Z

contributing/getting-started-e2e.md

+
+In general we cut a release of amphtml on Thursdays during working hours (Pacific time) and push it to the AMP Dev Channel that day.  After verifying there are no issues, we start rolling that build out the following Monday and complete the push that Thursday.
+
+You can see whether your change made it into the Dev Channel or production build on the [amphtml Releases page](https://github.com/ampproject/amphtml/releases).  The build marked `Draft` is the version on the Dev Channel and the build marked `Latest Release` is what is running in production.  Your Pull Request will be listed in the first build that includes it; if you don't see your Pull Request listed it will likely be in the next build.


It should be marked "pre-release", not Draft. Draft releases cannot be seen by non-project members.

Got it; I was trying to reverse engineer the labels from where the Releases page was and what was currently on canary. I talked to @erwinmombay about it and realized they temporarily didn't have the right labels. :)

erwinmombay · 2017-02-21T18:00:56Z

contributing/getting-started-e2e.md

+
+In general we cut a release of amphtml on Thursdays during working hours (Pacific time) and push it to the AMP Dev Channel that day.  After verifying there are no issues, we start rolling that build out the following Monday and complete the push that Thursday.
+
+You can see whether your change made it into the Dev Channel or production build on the [amphtml Releases page](https://github.com/ampproject/amphtml/releases).  The build marked `Draft` is the version on the Dev Channel and the build marked `Latest Release` is what is running in production.  Your Pull Request will be listed in the first build that includes it; if you don't see your Pull Request listed it will likely be in the next build.


it should be "the latest build marked with prerelease is the version on dev channel"

erwinmombay · 2017-02-21T18:02:35Z

contributing/getting-started-quick.md

+# See your changes in production
+
+* Barring any issues releases are cut Thursday, pushed to Dev Channel immediately, pushed to 1% on Monday and pushed to all of prod on Thursday.
+* The [amphtml Releases page](https://github.com/ampproject/amphtml/releases) will list your PR in the first build that contains it.  `Draft` is the build on the Dev Channel, `Latest Release` is the build in production.


update draft here too with "latest prerelease"

erwinmombay · 2017-02-21T18:03:45Z

contributing/getting-started-e2e.md


 # pull in the latest changes from the remote amphtml repository
-git pull upstream master 
+git pull upstream master


this assumes upstream is ampproject/amphtml right?

Yes; for the Getting Started guides we lead people through setting up the upstream alias to that. More advanced users can set it to whatever they want, but for the most part in these guides we try to stay away from providing too many options. :)

mrjoro

I also added README to reflect that we actually cut the next release on Wednesdays (since this can affect when people plan to get their work in by).

mrjoro · 2017-02-21T20:24:03Z

contributing/getting-started-e2e.md


 # pull in the latest changes from the remote amphtml repository
-git pull upstream master 
+git pull upstream master


Yes; for the Getting Started guides we lead people through setting up the upstream alias to that. More advanced users can set it to whatever they want, but for the most part in these guides we try to stay away from providing too many options. :)

mrjoro · 2017-02-21T20:25:39Z

contributing/getting-started-e2e.md

+
+If your change affected internal documentation, tests, the build process, etc. you can generally see your changes right after they're merged.  If your change was to the code that runs on AMP pages across the web you'll have to wait for the change to be included in a release.
+
+In general we cut a release of amphtml on Thursdays during working hours (Pacific time) and push it to the AMP Dev Channel that day.  After verifying there are no issues, we start rolling that build out the following Monday and complete the push that Thursday.


mrjoro · 2017-02-21T20:28:10Z

contributing/getting-started-e2e.md

+
+In general we cut a release of amphtml on Thursdays during working hours (Pacific time) and push it to the AMP Dev Channel that day.  After verifying there are no issues, we start rolling that build out the following Monday and complete the push that Thursday.
+
+You can see whether your change made it into the Dev Channel or production build on the [amphtml Releases page](https://github.com/ampproject/amphtml/releases).  The build marked `Draft` is the version on the Dev Channel and the build marked `Latest Release` is what is running in production.  Your Pull Request will be listed in the first build that includes it; if you don't see your Pull Request listed it will likely be in the next build.


Got it; I was trying to reverse engineer the labels from where the Releases page was and what was currently on canary. I talked to @erwinmombay about it and realized they temporarily didn't have the right labels. :)

mrjoro · 2017-02-21T20:28:19Z

contributing/getting-started-e2e.md

+
+In general we cut a release of amphtml on Thursdays during working hours (Pacific time) and push it to the AMP Dev Channel that day.  After verifying there are no issues, we start rolling that build out the following Monday and complete the push that Thursday.
+
+You can see whether your change made it into the Dev Channel or production build on the [amphtml Releases page](https://github.com/ampproject/amphtml/releases).  The build marked `Draft` is the version on the Dev Channel and the build marked `Latest Release` is what is running in production.  Your Pull Request will be listed in the first build that includes it; if you don't see your Pull Request listed it will likely be in the next build.


mrjoro · 2017-02-21T20:30:26Z

contributing/getting-started-quick.md

+
+# See your changes in production
+
+* Barring any issues releases are cut Thursday, pushed to Dev Channel immediately, pushed to 1% on Monday and pushed to all of prod on Thursday.


mrjoro · 2017-02-21T20:30:45Z

contributing/getting-started-quick.md

+# See your changes in production
+
+* Barring any issues releases are cut Thursday, pushed to Dev Channel immediately, pushed to 1% on Monday and pushed to all of prod on Thursday.
+* The [amphtml Releases page](https://github.com/ampproject/amphtml/releases) will list your PR in the first build that contains it.  `Draft` is the build on the Dev Channel, `Latest Release` is the build in production.


mrjoro · 2017-02-22T04:08:06Z

I can't merge; @erwinmombay if it looks okay can you merge when you have a chance?

erwinmombay · 2017-02-22T17:36:17Z

@mrjoro done

* first draft * added details inline; added quick start * added a preface for doc/test/etc. changes * minor fixes * responding to review comments; adding README

mrjoro added the Related to: Documentation label Feb 20, 2017

mrjoro added this to the Docs Updates milestone Feb 20, 2017

mrjoro requested a review from erwinmombay February 20, 2017 18:59

cramforce reviewed Feb 21, 2017

View reviewed changes

erwinmombay reviewed Feb 21, 2017

View reviewed changes

mrjoro added 5 commits February 21, 2017 11:54

first draft

6da090e

added details inline; added quick start

f081453

added a preface for doc/test/etc. changes

80e13c0

minor fixes

dfef854

responding to review comments; adding README

531e88d

mrjoro force-pushed the mrjoro-update-contributing branch from 1583c43 to 531e88d Compare February 21, 2017 20:49

mrjoro commented Feb 21, 2017

View reviewed changes

cramforce approved these changes Feb 21, 2017

View reviewed changes

erwinmombay merged commit 2212a10 into ampproject:master Feb 22, 2017

mrjoro deleted the mrjoro-update-contributing branch February 22, 2017 21:26

mrjoro mentioned this pull request Feb 27, 2017

Weekly Status 2017-02-27 #7813

Closed


		# See your changes in production

		* Barring any issues releases are cut Thursday, pushed to Dev Channel immediately, pushed to 1% on Monday and pushed to all of prod on Thursday.


		If your change affected internal documentation, tests, the build process, etc. you can generally see your changes right after they're merged. If your change was to the code that runs on AMP pages across the web you'll have to wait for the change to be included in a release.

		In general we cut a release of amphtml on Thursdays during working hours (Pacific time) and push it to the AMP Dev Channel that day. After verifying there are no issues, we start rolling that build out the following Monday and complete the push that Thursday.


		In general we cut a release of amphtml on Thursdays during working hours (Pacific time) and push it to the AMP Dev Channel that day. After verifying there are no issues, we start rolling that build out the following Monday and complete the push that Thursday.

		You can see whether your change made it into the Dev Channel or production build on the [amphtml Releases page](https://github.com/ampproject/amphtml/releases). The build marked `Draft` is the version on the Dev Channel and the build marked `Latest Release` is what is running in production. Your Pull Request will be listed in the first build that includes it; if you don't see your Pull Request listed it will likely be in the next build.

Conversation

mrjoro commented Feb 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrjoro left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrjoro commented Feb 22, 2017

Uh oh!

erwinmombay commented Feb 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants