For the validator CLI, set the exit code correctly even for Node.js v0.10.25 (very old).#7558
Merged
powdercloud merged 1 commit intoampproject:masterfrom Feb 14, 2017
powdercloud:ancient-node-js
Merged
For the validator CLI, set the exit code correctly even for Node.js v0.10.25 (very old).#7558powdercloud merged 1 commit intoampproject:masterfrom powdercloud:ancient-node-js
powdercloud merged 1 commit intoampproject:masterfrom
powdercloud:ancient-node-js
Conversation
is to avoid using process.exitCode and instead use process.exit, but do so inside the callback for process.(stdout or stderr).write.
honeybadgerdontcare
approved these changes
Feb 14, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…project#7558) is to avoid using process.exitCode and instead use process.exit, but do so inside the callback for process.(stdout or stderr).write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is to avoid using process.exitCode and instead use process.exit, but do so inside the callback for process.stdout.write or process.stderr.write.
I still care about compatibility this far back because Ubuntu 14.04 LT uses this Node.js version by default. (http://packages.ubuntu.com/trusty/nodejs). While most Javascript programmers will install a more recent version, it's still good to have the CLI work out of the box for less technical users.