Updating 4.3-dev with changes from 4.2-dev#38733
Merged
obuisard merged 42 commits intojoomla:4.3-devfrom Sep 10, 2022
Merged
Conversation
There were two bugs addressed 1. The dropdown scripts was only being loaded on a split button - it was needed for both 2. Instead of using the htmlhelper it should have been using trhe web asset manager To test disable the User Status Module and apply this pr Go to any list view and check that the actions dropdown works as expected
* Codestyle indent Small change to fix codestyle indent code review * Update default.php * more
Change css to logical proprty to make sure it works as intended in RTL and LTR
Fixes missing rtl styling by using logical properties
I dont believe this class is used in core but it is clearly wrong for an rtl site. So this PR changes it to a logical property so that it works the same in RTL and LTR. Code review
Changes the css to use logical properties so that the sidebar is indented the same in RTL as it is in LTR
Removes the property float:left as it is not used due to the additional class float-start applied to the same element. (makes it easier to convert to use logical properties if we don't have unused css)
small width adjustment on the checkbox to ensure it is visible on all browsers.
due to the daft RTL overrides we have in place the search boxes on the new module and new scheduled tasks pages are not centered in RTL. without changing the daft RTL overrides (which really should be done) this PR fixes the problem by using the correct css for centering a block
* Use the right mime type in the the media field * Update joomla-field-media.w-c.es6.js * Update joomla-field-media.w-c.es6.js
The default values in the xml include woff2 The default value in the db does not include woff2 The default values on a new install should match those in the component xml and this PR corrects that. We can't fix it on update as that would be changing user data. To test either code review or do a clean install from the provided build
The help button was missing for the options screen of both Scheduled Tasks and Media Testing is esy. Apply the pr go to the component and c;lick on options before this PR thwere is no help button - now there is
In german Tupel would be correct, but in english the variable has to be named "tuple".
Co-authored-by: Harald Leithner <leithner@itronic.at>
Pull request for joomla#38512 When there is only a next button it is no longer on the right as intended. this was due to a change in the markup. As this a change in the scss you will need to either `npm run build:css` or use one of the prebuilt packages
This PR removes a block of duplicated code. They two blocks are slightly different as the home is in a different place. But as the first block is overridden by the second block I have deleted the first block. There is no visible changes as a result of this PR. Either test by code review or by checking that you can still create and edit menu items exactly the same as before this PR
Display the existing description
* [4.2] Column Width Changes the css classes for the dropdown column selector to remove text wrapping * remove bottom margin as requested
Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
|
Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.