Keep user.css last in order#38368
Merged
fancyFranci merged 2 commits intojoomla:4.2-devfrom Sep 6, 2022
Merged
Conversation
wilsonge
approved these changes
Aug 1, 2022
Contributor
|
I have tested this item ✅ successfully on 0ef84ef This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38368. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 0ef84ef This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38368. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38368. |
Contributor
|
I have tested this item ✅ successfully on 0ef84ef This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38368. |
Contributor
|
Thanks Fedik! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38345 .
Summary of Changes
Currently user.css loaded after template.css. however the modules css goes after.
This patch make user.css to be as last css in loaded stylesheets, as long as it not violate any dependency.
Testing Instructions
Apply patch. Create user.css.
Inspect the source page for list of loaded stylesheets. Check that user.css is last in the list.
Also follow #38345
Actual result BEFORE applying this Pull Request
Not always last, when there a module css.
Expected result AFTER applying this Pull Request
Always last
Documentation Changes Required
No, I guess.