Skip to content

Language override RTL#38352

Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom
brianteeman:finder3
Sep 5, 2022
Merged

Language override RTL#38352
wilsonge merged 1 commit intojoomla:4.2-devfrom
brianteeman:finder3

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Jul 31, 2022 •
edited by Quy
Loading

Summary of Changes

Change css to logical proprty to make sure it works as intended in RTL and LTR

Testing Instructions

This is a css change so either run npm build:css or use a [re-built package
LTR
image

RTL
image

Actual result BEFORE applying this Pull Request

LTR
image

RTL
image

Expected result AFTER applying this Pull Request

Documentation Changes Required

@brianteeman
Language override RTL
12cf1e3 
Change css to logical proprty to make sure it works as intended in RTL and LTR
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Jul 31, 2022
@tecpromotion
Copy link
Copy Markdown
Contributor

tecpromotion commented Aug 1, 2022

works for me.
screen shot 2022-08-01 at 07 52 44

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38352.

@tecpromotion
Copy link
Copy Markdown
Contributor

tecpromotion commented Aug 1, 2022

I have tested this item ✅ successfully on 12cf1e3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38352.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Aug 1, 2022

I have tested this item ✅ successfully on 12cf1e3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38352.

@Quy Quy removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Aug 1, 2022
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Aug 1, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38352.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester RTC This Pull Request is Ready To Commit labels Aug 1, 2022
@wilsonge wilsonge merged commit d19ac0b into joomla:4.2-dev Sep 5, 2022
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Sep 5, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 5, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.3 milestone Sep 5, 2022
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Sep 5, 2022

thanks

@brianteeman brianteeman deleted the finder3 branch September 5, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Milestone

Joomla! 4.2.3

Development

Successfully merging this pull request may close these issues.

5 participants

@brianteeman @tecpromotion @Quy @wilsonge @joomla-cms-bot