Fix to prevent double modification of the module content by chrome style#38582
Merged
fancyFranci merged 2 commits intojoomla:4.2-devfrom Sep 6, 2022
Merged
Fix to prevent double modification of the module content by chrome style#38582fancyFranci merged 2 commits intojoomla:4.2-devfrom
fancyFranci merged 2 commits intojoomla:4.2-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 8e742c9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38582. |
Contributor
|
I have tested this item ✅ successfully on 8e742c9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38582. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38582. |
Contributor
|
Thank you very much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative fix for #38571 which for for #37147 and #12888
Summary of Changes
Clone a module before render "chrome" style, to avoid content duplication
Testing Instructions
Please follow #38571
Actual result BEFORE applying this Pull Request
Doubled content
Expected result AFTER applying this Pull Request
Works fine
Documentation Changes Required
nope