Merged
Conversation
Changes the css classes for the dropdown column selector to remove text wrapping
Contributor
|
looks good to me. thanks @brianteeman ! |
Contributor
|
I have tested this item ✅ successfully on e5421a9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507. |
Contributor
|
Result test: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507. |
Contributor
|
I have tested this item ✅ successfully on e5421a9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507. |
Contributor
|
@brianteeman Could the margin, at the bottom of the ul-element, be removed |
Contributor
Author
|
Bottom margin removed as requested |
Contributor
|
I have tested this item ✅ successfully on 30a9c9d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 30a9c9d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507. |
Contributor
|
Thanks! |
Contributor
Author
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the css classes for the dropdown column selector to remove text wrapping which is especially a problem in German but can also be seen in english in the category list view
Pull Request for Issue #38503 .
Testing Instructions
Either npm run build:js or install a prebuilt package
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required