Skip to content

Language override both#38627

Merged
fancyFranci merged 1 commit intojoomla:4.2-devfrom
brianteeman:both_locations
Sep 6, 2022
Merged

Language override both#38627
fancyFranci merged 1 commit intojoomla:4.2-devfrom
brianteeman:both_locations

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

When you create a language override there is an option to create the override in both the admin and site language. However this is only available if you have selected as admin language.

I can see no logical reason for this restriction today. Its very frustrating to have to create an override twice just because you selected site as the client first.

This PR removes the restriction

To test create a new override by selecting the language and site
Create an override and check the box for both locations
In the list of overrides you should now see it listed in both locations

image

When you create a language override there is an option to create the override in both the admin and site language. However this is only available if you have selected as admin language.

I can see no logical reason for this restriction today. Its very frustrating to have to create an override twice just because you selected site as the client first.

This PR removes the restriction

To test create a new override by selecting the language and site
Create an override and check the box for both locations
In the list of overrides you should now see it listed in both locations
@ChristineWk
Copy link
Copy Markdown

I have tested this item ✅ successfully on d540941


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38627.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on d540941


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38627.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Aug 29, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38627.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 29, 2022
@fancyFranci fancyFranci merged commit 3ef92e5 into joomla:4.2-dev Sep 6, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2022
@fancyFranci
Copy link
Copy Markdown
Contributor

Thank you for the improvement!

@fancyFranci fancyFranci added this to the Joomla! 4.2.3 milestone Sep 6, 2022
@brianteeman
Copy link
Copy Markdown
Contributor Author

thanks

@brianteeman brianteeman deleted the both_locations branch September 6, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants