Skip to content

com_finder rtl#38351

Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom
brianteeman:finder2
Sep 5, 2022
Merged

com_finder rtl#38351
wilsonge merged 1 commit intojoomla:4.2-devfrom
brianteeman:finder2

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Summary of Changes

Fixes missing rtl styling by using logical properties

Testing Instructions

This is a css change so either run npm build:css or use a [re-built package

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

Fixes missing rtl styling by using logical properties
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Jul 31, 2022
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Aug 3, 2022

I have tested this item ✅ successfully on a63f09d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38351.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on a63f09d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38351.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Aug 4, 2022
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Aug 4, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38351.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 4, 2022
@Quy Quy added the PR-4.2-dev label Aug 4, 2022
@wilsonge wilsonge merged commit a36d4ef into joomla:4.2-dev Sep 5, 2022
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Sep 5, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Sep 5, 2022
@wilsonge wilsonge modified the milestones: Joomla! 4.3.0, Joomla! 4.2.3 Sep 5, 2022
@brianteeman
Copy link
Copy Markdown
Contributor Author

thanks

@brianteeman brianteeman deleted the finder2 branch September 5, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants