Skip to content

Missing am/pm in calendar#38562

Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom
brianteeman:time_calendar
Sep 6, 2022
Merged

Missing am/pm in calendar#38562
wilsonge merged 1 commit intojoomla:4.2-devfrom
brianteeman:time_calendar

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Aug 23, 2022

Summary of Changes

If the time format is 12hr then the am/pm dropdown is not large enough

Testing Instructions

  1. Apply the PR and rebuild the js or use a prebuilt package
  2. change any date field to add timeformat="12" in the xml

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Aug 23, 2022
@RickR2H
Copy link
Copy Markdown
Member

RickR2H commented Aug 23, 2022

I have tested this item ✅ successfully on 3b012d4

I used mod_articles_category.xml to test. I added timeformat="12" the start_date_range field. The am/pm is now visible!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38562.

@viocassel
Copy link
Copy Markdown
Contributor

viocassel commented Aug 23, 2022

I have tested this item ✅ successfully on 3b012d4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38562.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Aug 23, 2022
@RickR2H
Copy link
Copy Markdown
Member

RickR2H commented Aug 23, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38562.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 23, 2022
@richard67 richard67 added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Aug 23, 2022
@wilsonge wilsonge merged commit ecc2cf0 into joomla:4.2-dev Sep 6, 2022
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Sep 6, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.3 milestone Sep 6, 2022
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Sep 6, 2022

thanks

@brianteeman brianteeman deleted the time_calendar branch September 6, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Milestone

Joomla! 4.2.3

Development

Successfully merging this pull request may close these issues.

6 participants

@brianteeman @RickR2H @viocassel @wilsonge @richard67 @joomla-cms-bot