Merged
Conversation
This PR removes a block of duplicated code. They two blocks are slightly different as the home is in a different place. But as the first block is overridden by the second block I have deleted the first block. There is no visible changes as a result of this PR. Either test by code review or by checking that you can still create and edit menu items exactly the same as before this PR
Contributor
|
I have tested this item ✅ successfully on 4a48516
|
Contributor
|
I have tested this item ✅ successfully on 4a48516 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38669. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38669. |
Contributor
|
Thanks! |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a block of duplicated code. They two blocks are slightly different as the home is in a different place. But as the first block is overridden by the second block I have deleted the first block.
There is no visible changes as a result of this PR. Either test by code review or by checking that you can still create and edit menu items exactly the same as before this PR
(any comments about codestyle will be ignored as out of scope for this pr)