Change bulk unarchive action for redirect links to unpublish#38434
Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom Sep 6, 2022
mattelkins-bluefrontier:com-redirect-links-unarchive
Merged
Change bulk unarchive action for redirect links to unpublish#38434wilsonge merged 1 commit intojoomla:4.2-devfrom mattelkins-bluefrontier:com-redirect-links-unarchive
wilsonge merged 1 commit intojoomla:4.2-devfrom
mattelkins-bluefrontier:com-redirect-links-unarchive
Conversation
Contributor
|
I have tested this item ✅ successfully on ec3f60c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38434. |
Contributor
|
I have tested this item ✅ successfully on ec3f60c RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38434. |
Member
|
@N6REJ You should know that seeting the RTC label only is not sufficient. It needs to change the status on github to "Ready to commit". I'll do that for you now, but hopefully you remember next time. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38434. |
Contributor
|
Thankyou for you first PR to the project! Much appreciated! |
Contributor
Author
Thanks! Glad to be able to contribute! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38434.
Summary of Changes
Attempting to unarchive multiple redirect links using the 'Unarchive' option in the Actions dropdown currently has no effect. When unarchiving individual redirect links, the unpublish action is used to set them to the 'Disabled' state. This update applies the same unpublish action to the bulk unarchive option.
Testing Instructions
Actual result BEFORE applying this Pull Request
A form submission occurs, the page reloads, but the selected redirect links remain archived.
Expected result AFTER applying this Pull Request
The selected redirect links will be set to the unpublished/'Disabled' state.
Documentation Changes Required
None.