[4.2] Small fixes in MFA#38208
Merged
fancyFranci merged 21 commits intojoomla:4.2-devfrom Sep 7, 2022
Kostelano:4-2-mfa
Merged
[4.2] Small fixes in MFA#38208fancyFranci merged 21 commits intojoomla:4.2-devfrom Kostelano:4-2-mfa
fancyFranci merged 21 commits intojoomla:4.2-devfrom
Kostelano:4-2-mfa
Conversation
It is used as the page title for authentication. But also the old header was the header in the users table and in many languages (including Russian, which I'm currently working on) it makes sense to "shorten" it to MFA.
Member
|
@nikosdion can you have a look here? |
nikosdion
suggested changes
Jul 3, 2022
nikosdion
approved these changes
Jul 5, 2022
Contributor
|
@Kostelano Could you please also correct the lang key in the description here: 
|
Contributor
Author
|
@heelc29 Thanks, corrected. Also fixed the display of the NONE position for modules - the line is duplicated. This can happen when you install a large package of extensions, but it is not at all the fact that you will use all the modules, say. In this case, they will be in the NONE position. This can confuse users.
At this point I have everything for this PR. Please test. |
Contributor
|
I have tested this item ✅ successfully on 3ecd7cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38208. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 3ecd7cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38208. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38208. |
Contributor
|
Thanks a lot for your work! |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 23, 2022
joomla/joomla-cms#38670 - (только для en-GB) joomla/joomla-cms#38463 + joomla/joomla-cms#38703 - (только для en-GB) joomla/joomla-cms#38208 + joomla/joomla-cms#38704 - (только для en-GB) joomla/joomla-cms#38732 - (только для en-GB) joomla/joomla-cms#38772 - (только для en-GB) joomla/joomla-cms#38596 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
showon="mfaredirectonlogin:1"for Onboard new users / Custom redirection URL parameters.COM_USERS_HEADING_MFAwithCOM_USERS_USER_MULTIFACTOR_AUTH, because the first key is also the heading in the users table. For many languages, it makes sense to reduce it to MFA, so as not to inflate an already large table. However, the same key was used on the authentication page when logging in - the short MFA is inappropriate there, the full name is needed.PLG_MULTIFACTORAUTH_EMAIL_MAIL_LBL="Joomla: Authentication Code by Email"was never used.For 2 methods, the'placeholder'elements were missing when authenticating on the site (after setting up the methods).