Merged
Conversation
The batch process on users lets you remove a user from a group. But it doesn't check to make sure that the user is still in at least one group. ## To test ### Test 1 1. Create a new user and put them in the registered usergroup 2. Using the batch process try to remove them from the registered usergroup #### Before Success message and user now not in any group #### After Batch process failed with following error: A user must belong to at least one group. ### Test 2 1. Create a new user and put them in the registered AND author usergroup 2. Using the batch process try to remove them from the editor usergroup #### Before Success message and user still in the registered and author usergroups #### After Batch process failed with following error: The selected user(s) are not in the selected group. ### Test 3 1. Create a new user and put them in the registered AND author usergroup 2. Using the batch process try to remove them from the registered usergroup #### Before Success message and user only in the author usergroup #### After Success message and user only in the author usergroup #### Comments This type of code is really not my strong point - it may need optimizing etc
sandewt
reviewed
Aug 25, 2022
|
I have tested this item ✅ successfully on 2081df5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38596. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 2081df5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38596. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38596. |
Contributor
|
I remember a rule that comments have to start with a capital lettter? |
Contributor
Author
|
@chmst yes you're right my bad. also the multiline comment should not use // suprised the code style check didnt pick this up. I will update shortly |
Contributor
|
Thank you! Great branch name :D |
Contributor
Author
|
Wow this gets merged but removing unused CSS doesn't. Makes no sense |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Sep 23, 2022
joomla/joomla-cms#38670 - (только для en-GB) joomla/joomla-cms#38463 + joomla/joomla-cms#38703 - (только для en-GB) joomla/joomla-cms#38208 + joomla/joomla-cms#38704 - (только для en-GB) joomla/joomla-cms#38732 - (только для en-GB) joomla/joomla-cms#38772 - (только для en-GB) joomla/joomla-cms#38596 +
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for #32732
The batch process on users lets you remove a user from a group. But it doesn't check to make sure that the user is still in at least one group.
To test
Test 1
Before
Success message and user not in any group
After
Batch process failed with following error: A user must belong to at least one group.
Test 2
Before
Success message and user still in the registered and author usergroups
After
Batch process failed with following error: The selected user(s) are not in the selected group.
Test 3
Before
Success message and user only in the author usergroup
After
Success message and user only in the author usergroup
Comments
This type of code is really not my strong point - it may need optimizing etc