Merged
Conversation
There were two _bugs_ 1. The dropdown scripts was only being loaded on a split button - it was needed for both 2. Instead of using the htmlhelper it should have been using trhe web asset manager To test disable the User Status Module and apply this pr Go to any list view and check that the actions dropdown works as expected
|
I have tested this item ✅ successfully on fa0849e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38644. |
Contributor
|
Seems that there are more files in the PR than needed? |
This reverts commit 6ea2ef94f7a0af75b89bf5fe0f65b27c91ed0fe5.
Contributor
Author
fixed |
dgrammatiko
reviewed
Aug 30, 2022
Contributor
|
I have tested this item ✅ successfully on 16bcfe0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38644. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 16bcfe0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38644. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38644. |
Contributor
|
OK This one wasn't intuitive to me - had to dig back through the comments on the previous issue - added a code comment with reasoning to help stop it being reverted accidentally in the future. RTC is still valid |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two bugs
To test disable the User Status Module and apply this pr
Go to any list view and check that the actions dropdown works as expected
Pull Request for Issue #38640