Supported font formats mismatch#38465
Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom Sep 6, 2022
Merged
Conversation
The default values in the xml include woff2 The default value in the db does not include woff2 The default values on a new install should match those in the component xml and this PR corrects that. We can't fix it on update as that would be changing user data. To test either code review or do a clean install from the provided build
|
I have tested this item ✅ successfully on 428c630 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38465. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 428c630 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38465. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38465. |
wilsonge
approved these changes
Aug 18, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default values in the xml include woff2
The default value in the db does not include woff2
The default values on a new install should match those in the component xml and this PR corrects that.
We can't fix it on update as that would be changing user data.
To test either code review or do a clean install from the provided build