Skip to content

Pagination Only child#38612

Merged
wilsonge merged 1 commit intojoomla:4.2-devfrom
brianteeman:pagination_only_child
Sep 6, 2022
Merged

Pagination Only child#38612
wilsonge merged 1 commit intojoomla:4.2-devfrom
brianteeman:pagination_only_child

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Aug 26, 2022 •
edited
Loading

Pull request for #38512

When there is only a next button it is no longer on the right as intended. this was due to a change in the markup.

As this a change in the scss you will need to either npm run build:css or use one of the prebuilt packages

Before

image

After

image

@brianteeman
Pagination Only child
872838f 
Pull request for joomla#38512

When there is only a next button it is no longer on the right as intended. this was due to a change in the markup.

As this a change in the scss you will need to either `npm run build:css` or use one of the prebuilt packages
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Aug 26, 2022
@brianteeman brianteeman mentioned this pull request Aug 26, 2022
Closed
@sandewt
Copy link
Copy Markdown
Contributor

sandewt commented Aug 27, 2022

I'm not a designer, but the button looks very small, please make it a bit bigger. Add p-2.

E.g. class="btn p-2 btn-sm btn-secondary next"

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Aug 27, 2022

I am not changing the size, just fixing the bug

@sandewt
Copy link
Copy Markdown
Contributor

sandewt commented Aug 27, 2022

I am not changing the size, just fixing the bug

That would be a new PR.

@sandewt
Copy link
Copy Markdown
Contributor

sandewt commented Aug 27, 2022

English: successful test

issue_38612

Arabic: successful test ???
Can anyone confirm that this test is also successful.

issue_38612-2

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Aug 28, 2022

@N6REJ you have a template override in place

@N6REJ
Copy link
Copy Markdown
Contributor

N6REJ commented Aug 28, 2022

@N6REJ you have a template override in place

nope, I hadn't ran npm ci

@N6REJ
Copy link
Copy Markdown
Contributor

N6REJ commented Aug 28, 2022

I have tested this item ✅ successfully on 872838f

works after running npm ci as instructed

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Aug 28, 2022
@N6REJ N6REJ added the RTC This Pull Request is Ready To Commit label Aug 28, 2022
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Aug 28, 2022

@N6REJ you have a template override in place

nope, I hadn't ran npm ci

well you have an extra class there thats not in core docs-creator

@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Aug 28, 2022
@N6REJ
Copy link
Copy Markdown
Contributor

N6REJ commented Aug 28, 2022 •
edited
Loading

@N6REJ you have a template override in place

nope, I hadn't ran npm ci

well you have an extra class there thats not in core docs-creator

that is fresh 4.2 install with blog sample data . I'll check the *ampp stack

@N6REJ
Copy link
Copy Markdown
Contributor

N6REJ commented Aug 28, 2022 •
edited
Loading

@brianteeman ok, it comes from an extension for chrome called Docs Creator

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Aug 28, 2022

see I'm not daft

@richard67
Copy link
Copy Markdown
Member

richard67 commented Aug 28, 2022

@brianteeman Is the screenshot for RTL in @sandewt 's comment above ok? He was not sure if his test with Arabic can be counted as success. I think it's because of the position of the button, it seems to have some margin left which it doesn's have with LTR.

@N6REJ As there was one test only, i.e. yours, it cannot be RTC. @sandewt test for RTL (Arabic) was not clear.

@richard67 richard67 removed the RTC This Pull Request is Ready To Commit label Aug 28, 2022
@richard67
Copy link
Copy Markdown
Member

richard67 commented Aug 28, 2022

Back to pending.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Aug 28, 2022

Yes that's fine as an RTL trst

@richard67
Copy link
Copy Markdown
Member

richard67 commented Aug 28, 2022

@sandewt As @brianteeman confirmed that your test for RTL direction with Arabic is ok, I was so free to set your test result to success.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Aug 28, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 28, 2022
@sandewt
Copy link
Copy Markdown
Contributor

sandewt commented Aug 28, 2022

I was so free to set your test result to success.

@richard67 that's OK. Thks.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.

@wilsonge wilsonge merged commit f49411d into joomla:4.2-dev Sep 6, 2022
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Sep 6, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.3 milestone Sep 6, 2022
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Sep 6, 2022

thanks

@brianteeman brianteeman deleted the pagination_only_child branch September 6, 2022 10:37
@alikon alikon mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Milestone

Joomla! 4.2.3

Development

Successfully merging this pull request may close these issues.

6 participants

@brianteeman @sandewt @N6REJ @richard67 @wilsonge @joomla-cms-bot