Skip to content

Batch copy fields#38682

Merged
fancyFranci merged 2 commits intojoomla:4.2-devfrom
brianteeman:batch_copy_fields
Sep 6, 2022
Merged

Batch copy fields#38682
fancyFranci merged 2 commits intojoomla:4.2-devfrom
brianteeman:batch_copy_fields

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Pull Request for Issue #37555

Summary of Changes

Batch copy field did not generate new name and label and you end up with invalid data as you have multiple fields with the same name (but diffeerent id)

Testing Instructions

Create three fields - one, two three
Use batch copy to copy those fields in the saame group
Verify that three new fields have been created - one (2), two (2), three, (3)
Publish all three fields
Open an article for editing

Actual result BEFORE applying this Pull Request

The fields tab only has 3 fields not the expected 6

Expected result AFTER applying this Pull Request

fields tab has 6 fields

Documentation Changes Required

none

@toivo
Copy link
Copy Markdown
Contributor

toivo commented Sep 5, 2022

I have tested this item ✅ successfully on da66f71

Tested successfully in Joomla 4.2.3-dev of 5 September in Wampserver 3.2.9 and PHP 8.1.9.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38682.

@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on da66f71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38682.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Sep 5, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38682.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 5, 2022
@fancyFranci fancyFranci merged commit 835d986 into joomla:4.2-dev Sep 6, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2022
@fancyFranci
Copy link
Copy Markdown
Contributor

Thank you very much

@fancyFranci fancyFranci added this to the Joomla! 4.2.3 milestone Sep 6, 2022
@brianteeman brianteeman deleted the batch_copy_fields branch September 6, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants