Merged
Conversation
due to the daft RTL overrides we have in place the search boxes on the new module and new scheduled tasks pages are not centered in RTL. without changing the daft RTL overrides (which really should be done) this PR fixes the problem by using the correct css for centering a block
Contributor
|
I have tested this item ✅ successfully on bf60581 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38365. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on bf60581 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38365. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38365. |
Contributor
|
Thanks! |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to the daft RTL overrides we have in place the search boxes on the new module and new scheduled tasks pages are not centered in RTL.
without changing the daft RTL overrides (which really should be done) this PR fixes the problem by using the correct css for centering a block
New Module LTR
New Module RTL - BEFORE
New Module RTL - AFTER