Skip to content

Contact form captcha#38607

Merged
wilsonge merged 3 commits intojoomla:4.2-devfrom
brianteeman:captcha2
Sep 5, 2022
Merged

Contact form captcha#38607
wilsonge merged 3 commits intojoomla:4.2-devfrom
brianteeman:captcha2

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Aug 26, 2022

Pull Request for Issue #27407.

Summary of Changes

Moves the captcha to the end of the form.

Testing Instructions

  1. Enable recaptcha
  2. set the captcha in global config
  3. create a contact
  4. create custom contact fields for mails
  5. check the contact form on the front end - captcha displayed
  6. disable captcha in global config
  7. check the contact form on the front end - no captcha displayed
  8. enable captcha in the contact component
  9. check the contact form on the front end - captcha displayed

Actual result BEFORE applying this Pull Request

the captcha is rendered after the default fields but before any custom fields

Expected result AFTER applying this Pull Request

the captcha is rendered at the end of the form

@brianteeman
Contact form captcha
c7b902f 
Ensure that the captcha is at the end of the form
@brianteeman brianteeman mentioned this pull request Aug 26, 2022
Closed
@chmst
Copy link
Copy Markdown
Contributor

chmst commented Aug 26, 2022

A second loop over fieldsets is not necessary if you use a variable.

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Aug 26, 2022

@chmst I tried and failed. maybe my brain is still not fully functional. pr to my branches are welcome

@obuisard
Copy link
Copy Markdown
Contributor

obuisard commented Aug 26, 2022

I have tested this item ✅ successfully on 901a8ec

Perfect

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38607.

@ChristineWk
Copy link
Copy Markdown

ChristineWk commented Aug 26, 2022

I have tested this item ✅ successfully on 901a8ec

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38607.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Aug 26, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38607.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 26, 2022
@wilsonge wilsonge merged commit a23edde into joomla:4.2-dev Sep 5, 2022
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Sep 5, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 5, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.3 milestone Sep 5, 2022
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Sep 5, 2022

thanks

@brianteeman brianteeman deleted the captcha2 branch September 5, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 4.2.3

Development

Successfully merging this pull request may close these issues.

7 participants

@brianteeman @chmst @obuisard @ChristineWk @Quy @wilsonge @joomla-cms-bot