Skip to content

Use the right mime type in the the media field#38425

Merged
wilsonge merged 3 commits intojoomla:4.2-devfrom
dgrammatiko:patch-2
Sep 5, 2022
Merged

Use the right mime type in the the media field#38425
wilsonge merged 3 commits intojoomla:4.2-devfrom
dgrammatiko:patch-2

Conversation

@dgrammatiko
Copy link
Copy Markdown
Contributor

Pull Request for Issue #38333 .

Summary of Changes

The preview might get the wrong mime type in some cases.

Testing Instructions

  • Edit the file administrator/components/com_content/forms/article.xml and add types="images,audios,videos,documents" after
    label="COM_CONTENT_FIELD_IMAGE_CAPTION_LABEL"
  • Try to upload and select different type of media, especially video, audio and document (eg, mp3, mp4, mov, pdf, doc, docx, etc)

Actual result BEFORE applying this Pull Request

No preview in some cases

Expected result AFTER applying this Pull Request

Preview is ok

Documentation Changes Required

No

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Aug 8, 2022
@crystalenka
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on abd4aca

Thank you!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38425.

@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on abd4aca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38425.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Aug 9, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38425.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 9, 2022
@wilsonge wilsonge added the Maintainers Checked Used if the PR is conceptional useful label Aug 10, 2022
@wilsonge wilsonge merged commit 1d458dc into joomla:4.2-dev Sep 5, 2022
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Sep 5, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 5, 2022
@wilsonge wilsonge added this to the Joomla! 4.2.3 milestone Sep 5, 2022
@dgrammatiko dgrammatiko deleted the patch-2 branch September 5, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainers Checked Used if the PR is conceptional useful NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants