Release develop to master by snario · Pull Request #947 · ethereum-optimism/optimism

snario · 2021-05-24T18:34:56Z

This is not how `master` will be updated, it just shows the diff.

master will be rebased on develop and force pushed.

The following packages are currently deployed on our networks:

Goerli

l2geth: 0.3.0-rc4
dtl: 0.3.0-rc4
bs: 0.3.0-rc4

Kovan

l2geth: 0.3.1
dtl: 0.3.0
bs: 0.3.2

Mainnet

l2geth: 0.3.4
dtl: 0.3.0
bs: 0.3.2

Since mainnet is now up to date to those versions, we should update master on this repo.

* docs: add truffle example * fix: add gasPrice: 0 to all ctc calls and deploys * chore(truffle-example): use correct truffle command * fix: install missing packages * style: fix missing newlines * fix: attempt to fix yarn.lock (2) * Update integration.yml * specify truffle config and network * correctly specify path and version * relayer: logging cleanup (#807) * relayer: don't log options at startup * chore: add changeset * relayer: log specifc config options * config: message relayer (#809) * relayer: migrate towards prefixed config w/ backwards compat * chore: update relayer config parsing * env: use start-offset instead of block offset * lint: fix * deps: add bcfg * message-relayer: cleaner config parsing * lint: fix * Version Packages (#833) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: geth miner timestamp bug (#836) * l2geth: use correct timestamp protection * chore: add changeset * Version Packages (#837) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * style: require curly braces for if statements (#835) * test[integration-tests]: l2geth call and creation OOG (#839) * fix: WE DID IT Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ben-chain <ben@pseudonym.party>

* batch-submitter: log error explicitly * data-transport-layer: log error explicitly * message-relayer: log error explicitly * chore: add changeset

* example: get revert msgs for hardhat * fix: remove chai-as-promised dep and logic * re-add @types/mocha and @types/chai * Update examples/hardhat/package.json Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

* Update mainnet deployment * Remove old unused contracts * chore: regenerate readme * Change : to - in deploy files Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com>

* Removes '-v3' from kovan and goerli contracts folders * Generatees new README

* chore: update READMEs with new env vars * extra context in dtl readme * more context

* l2geth: update start script for mainnet v3 * chore: add changeset

* Update Github Actions for the develop branch * Rebased and updated changeset config

* l2geth: fix get last confirmed enqueue * chore: add changeset * client: return error correctly

* batch-submitter: backwards compatible configuration * chore: add changeset * deps: update * js: move bcfg interface to core-utils * batch-submitter: parse USE_SENTRY and add to env example * chore: add changeset * batch-submitter: parse as float instead of int * batch-submitter: better error logging

* maintenance: standardize license usage * fix: rename LICENSE.txt to LICENSE

* Links to new contributing guide * Adds 1 vs 2 reviewer list * More detail Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com>

* feat: add config for impersonating accounts to BS Useful for testing against hardhat forks. * Make block offset configurable (#865) * feat: make block offset configurable * Add a USE_HARDHAT config * batch-submitter: must pass both impersonate options (#866) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * batch-submitter: update example env * batch-submitter: lint fix * batch-submitter: clean up old comments * batch-submitter: USE_HARDHAT * batch-submitter: add error messages Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>

* Contracts: connectToL1Contracts & connectToL2Contrats (part 1) * chore: add changeset Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>

…#840) * l2geth: allow for the configured max tx gaslimit to be set in the contracts * chore: add changeset

* feat[batch-submitter]: add lightweight metrics server * add changeset * move metrics server to common

* dtl: update constant to 9 million gaslimit * dtl: parse as rlp without top level type * chore: add changeset * test: delete dead code * lint: fix * deps: add etherproject transactions * dtl: better handler for more number types * tests: fix chainid

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* optimism: syncing dtl with correct contracts * chore: add changeset

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Merge conflict * add: integration test * chore: cleanup deps * fix: nohoist examples so that paths get set correctly * chore: rename package.json script * chore: combine test statements into 1 previously the individually separate tests did not test anything meaningful * fix: get tests to pass * add yarn and fix typo * remove call to yarn * re-add call to yarn for first tests * revert compilerVersion paths to og * update ovm-solc path * update test commands * typo * final bug fix * cleaning * i will prevail * i will prevail * timeout to 60sec Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> > LGTM, it may be worth splitting the examples testing in a separate github workflow to reduce CI times, as they've become long.

* fix[batch-submitter]: read metrics env vars correctly * rename to metrics

…ock (#896) * feat[smock]: add support for sending txs from mocks * fix: remove unused imports * chore: add changeset * fix: readme errors * Update packages/smock/README.md * Update packages/smock/README.md Co-authored-by: Maurelian <maurelian@protonmail.ch> Co-authored-by: Maurelian <maurelian@protonmail.ch>

Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

…ents that run out of gas (#939) * test: add deploy OOG test and improve OOG error message * chore: add changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

…il data (#940) * fix(l2geth): do not throw an error when estimating gas for txs with nil data * chore: add changeset

changeset-bot · 2021-05-24T18:34:58Z

🦋 Changeset detected

Latest commit: ba72b1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@eth-optimism/data-transport-layer	Patch
@eth-optimism/l2geth	Patch
@eth-optimism/integration-tests	Patch
@eth-optimism/contracts	Patch
@eth-optimism/message-relayer	Patch
@eth-optimism/hardhat-ovm	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

snario · 2021-05-24T18:36:18Z

packages/contracts/contracts/optimistic-ethereum/OVM/accounts/OVM_ECDSAContractAccount.sol

            "Fee was not transferred to relayer."
        );

-        // Contract creations are signalled by sending a transaction to the zero address.


This is the only code changed to the contracts Solidity source code from master so far. However, the contracts package was bumped from 0.3.0 to 0.3.2.

There was an update to the state dump scripts

snario · 2021-05-24T18:38:37Z

l2geth/package.json

 {
  "name": "@eth-optimism/l2geth",
-  "version": "0.3.1",
+  "version": "0.3.4",


l2geth bump ^

snario · 2021-05-24T18:38:48Z

packages/batch-submitter/package.json

 {
  "name": "@eth-optimism/batch-submitter",
-  "version": "0.3.0",
+  "version": "0.3.2",


batch-submitter bump ^

snario · 2021-05-24T18:39:00Z

packages/data-transport-layer/package.json

@@ -1,12 +1,14 @@
 {
  "name": "@eth-optimism/data-transport-layer",
-  "version": "0.3.0",
+  "version": "0.3.2",


dtl bump ^

gakonst

LGTM. Don't forget the rebase!

* fix[message-relayer]: avoid getting OOM killed * chore: add changeset * fix some errors in cache eviction logic * make things a little more clear * slight refactor and add another function comment * more minor refactors for legibility * fix a bignumber bug

* feat[dtl]: add config switches for sentry and metrics * changeset and environment tag

* fix: impl suggestions * fix: bug

codecov-commenter · 2021-05-25T13:22:17Z

Codecov Report

Merging #947 (ba72b1d) into master (52d9e6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #947   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files          48       48           
  Lines        1895     1895           
  Branches      303      303           
=======================================
  Hits         1558     1558           
  Misses        337      337

Impacted Files	Coverage Δ
...ethereum/OVM/accounts/OVM_ECDSAContractAccount.sol	`0.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d9e6b...ba72b1d. Read the comment docs.

smartcontracts and others added 30 commits May 11, 2021 19:38

fix: have workflows run on develop (#845)

8d67991

fix: logging error messages and stack (#843)

fa4898a

* batch-submitter: log error explicitly * data-transport-layer: log error explicitly * message-relayer: log error explicitly * chore: add changeset

example: get revert msgs for hardhat (#841)

e88e85d

* example: get revert msgs for hardhat * fix: remove chai-as-promised dep and logic * re-add @types/mocha and @types/chai * Update examples/hardhat/package.json Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

Contracts: Removes '-v3' from kovan and goerli contracts folders (#844)

4390321

* Removes '-v3' from kovan and goerli contracts folders * Generatees new README

chore: update READMEs with new env vars (#842)

5ccf42e

* chore: update READMEs with new env vars * extra context in dtl readme * more context

l2 geth: start script mainnetv3 (#852)

de5e3dc

* l2geth: update start script for mainnet v3 * chore: add changeset

Update Github Actions for the develop branch (#856)

7d8d294

* Update Github Actions for the develop branch * Rebased and updated changeset config

fix: get last confirmed enqueue (#846)

20242af

* l2geth: fix get last confirmed enqueue * chore: add changeset * client: return error correctly

maintenance: standardize license usage (#861)

0d1ed67

* maintenance: standardize license usage * fix: rename LICENSE.txt to LICENSE

Link to new contributing guide (#867)

e1cc989

* Links to new contributing guide * Adds 1 vs 2 reviewer list * More detail Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com>

Contracts: connectToL1Contracts & connectToL2Contracts (part 1) (#858)

775118a

* Contracts: connectToL1Contracts & connectToL2Contrats (part 1) * chore: add changeset Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>

l2geth: allow for the configured max tx gaslimit to be set in the cfg (…

cf3cfe4

…#840) * l2geth: allow for the configured max tx gaslimit to be set in the contracts * chore: add changeset

feat[batch-submitter]: add lightweight metrics server (#792)

0c16805

* feat[batch-submitter]: add lightweight metrics server * add changeset * move metrics server to common

dtl: fix replica tx indexing (#872)

e28cec7

* dtl: update constant to 9 million gaslimit * dtl: parse as rlp without top level type * chore: add changeset * test: delete dead code * lint: fix * deps: add etherproject transactions * dtl: better handler for more number types * tests: fix chainid

Version Packages (#859)

cb2e9ad

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

fix: remove incorrect comment (#880)

7dd2f72

optimism: syncing dtl with correct contracts (#881)

f5185bb

* optimism: syncing dtl with correct contracts * chore: add changeset

Version Packages (#883)

5b7e13c

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

test(contracts): easily set storageXOR values in prestate (#879)

cc209be

fix[batch-submitter]: read metrics env vars correctly (#890)

9fea7c9

* fix[batch-submitter]: read metrics env vars correctly * rename to metrics

Batch submitter metrics collection for docker-compose. (#893)

a9d9638

chore: remove example yarn lockfiles (#901)

2d352de

Add Elena as a code owner of the contracts package (#902)

10d29f0

Co-authored-by: smartcontracts <kelvinfichter@gmail.com>

fix: add changeset for BS change (#911)

4340bb1

smartcontracts and others added 2 commits May 23, 2021 13:38

test[integration-tests]: add an integration test for contract deploym…

467d6cb

…ents that run out of gas (#939) * test: add deploy OOG test and improve OOG error message * chore: add changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>

fix(l2geth): do not throw an error when estimating gas for txs with n…

c880043

…il data (#940) * fix(l2geth): do not throw an error when estimating gas for txs with nil data * chore: add changeset

github-actions bot added A-ci A-op-batcher Area: op-batcher A-pkg-core-utils Area: packages/core-utils A-ops Area: ops labels May 24, 2021

snario commented May 24, 2021

View reviewed changes

snario requested a review from gakonst May 24, 2021 18:40

snario self-assigned this May 24, 2021

snario added the P-DO-NOT-MERGE label May 24, 2021

gakonst approved these changes May 24, 2021

View reviewed changes

smartcontracts and others added 4 commits May 24, 2021 15:55

feat[dtl]: add config switches for sentry and metrics (#950)

e4c3b4b

* feat[dtl]: add config switches for sentry and metrics * changeset and environment tag

fix(l2geth): add an env var METRICS_ENABLE for MetricsEnabledFlag (#934)

4e6c3f9

fix: reorg for clear proxy usage (#944)

ba72b1d

* fix: impl suggestions * fix: bug

snario mentioned this pull request May 25, 2021

Remove auto-publishing on develop; add canary tool #954

Merged

snario merged commit ba72b1d into master May 25, 2021

snario deleted the release-develop-to-master branch May 25, 2021 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release develop to master#947

Release develop to master#947
snario merged 49 commits intomasterfrom
release-develop-to-master

snario commented May 24, 2021 •

edited

Loading

Uh oh!

changeset-bot bot commented May 24, 2021 •

edited

Loading

Uh oh!

snario May 24, 2021

Uh oh!

gakonst May 24, 2021

Uh oh!

snario May 24, 2021

Uh oh!

snario May 24, 2021

Uh oh!

snario May 24, 2021

Uh oh!

gakonst left a comment

Uh oh!

codecov-commenter commented May 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

snario commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This is not how master will be updated, it just shows the diff.

Goerli

Kovan

Mainnet

Uh oh!

changeset-bot bot commented May 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

snario May 24, 2021

Choose a reason for hiding this comment

Uh oh!

gakonst May 24, 2021

Choose a reason for hiding this comment

Uh oh!

snario May 24, 2021

Choose a reason for hiding this comment

Uh oh!

snario May 24, 2021

Choose a reason for hiding this comment

Uh oh!

snario May 24, 2021

Choose a reason for hiding this comment

Uh oh!

gakonst left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented May 25, 2021

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

snario commented May 24, 2021 •

edited

Loading

This is not how `master` will be updated, it just shows the diff.

changeset-bot bot commented May 24, 2021 •

edited

Loading