Make block offset configurable#865
Merged
tynes merged 3 commits intofeat/batch-submitter-impersonationfrom May 13, 2021
Merged
Conversation
🦋 Changeset detectedLatest commit: 1ca8d31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
deb806c to
63c8984
Compare
Codecov Report
@@ Coverage Diff @@
## feat/batch-submitter-impersonation #865 +/- ##
===================================================================
Coverage 82.21% 82.21%
===================================================================
Files 48 48
Lines 1895 1895
Branches 303 303
===================================================================
Hits 1558 1558
Misses 337 337 Continue to review full report at Codecov.
|
63c8984 to
8738e2d
Compare
tynes
reviewed
May 13, 2021
| public async _getBatchStartAndEnd(): Promise<Range> { | ||
| this.logger.info('Getting batch start and end for state batch submitter...') | ||
| // TODO: Remove BLOCK_OFFSET by adding a tx to Geth's genesis | ||
| // TODO: Remove blockOffset by adding a tx to Geth's genesis |
tynes
reviewed
May 13, 2021
| DEBUG_IMPERSONATE_SEQUENCER_ADDRESS = env.DEBUG_IMPERSONATE_SEQUENCER_ADDRESS | ||
| DEBUG_IMPERSONATE_PROPOSER_ADDRESS = env.DEBUG_IMPERSONATE_PROPOSER_ADDRESS | ||
| if ( | ||
| !DEBUG_IMPERSONATE_SEQUENCER_ADDRESS || |
Contributor
There was a problem hiding this comment.
right now it says if either is set then throw an error. I think we should just enforce setting both of them
tynes
added a commit
that referenced
this pull request
May 13, 2021
* feat: make block offset configurable * Add a USE_HARDHAT config * batch-submitter: must pass both impersonate options (#866) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
tynes
added a commit
that referenced
this pull request
May 13, 2021
* feat: add config for impersonating accounts to BS Useful for testing against hardhat forks. * Make block offset configurable (#865) * feat: make block offset configurable * Add a USE_HARDHAT config * batch-submitter: must pass both impersonate options (#866) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * batch-submitter: update example env * batch-submitter: lint fix * batch-submitter: clean up old comments * batch-submitter: USE_HARDHAT * batch-submitter: add error messages Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
) * feat: add config for impersonating accounts to BS Useful for testing against hardhat forks. * Make block offset configurable (ethereum-optimism#865) * feat: make block offset configurable * Add a USE_HARDHAT config * batch-submitter: must pass both impersonate options (ethereum-optimism#866) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * batch-submitter: update example env * batch-submitter: lint fix * batch-submitter: clean up old comments * batch-submitter: USE_HARDHAT * batch-submitter: add error messages Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The BLOCK_OFFSET needs to be configurable.
Additional context
It is required because because sometimes Geth has more or fewer blocks than L1