feat/make block offset configurable fix#866
Merged
tynes merged 1 commit intofeat/make-block-offset-configurablefrom May 13, 2021
Merged
feat/make block offset configurable fix#866tynes merged 1 commit intofeat/make-block-offset-configurablefrom
tynes merged 1 commit intofeat/make-block-offset-configurablefrom
Conversation
|
tynes
added a commit
that referenced
this pull request
May 13, 2021
* feat: make block offset configurable * Add a USE_HARDHAT config * batch-submitter: must pass both impersonate options (#866) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
tynes
added a commit
that referenced
this pull request
May 13, 2021
* feat: add config for impersonating accounts to BS Useful for testing against hardhat forks. * Make block offset configurable (#865) * feat: make block offset configurable * Add a USE_HARDHAT config * batch-submitter: must pass both impersonate options (#866) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * batch-submitter: update example env * batch-submitter: lint fix * batch-submitter: clean up old comments * batch-submitter: USE_HARDHAT * batch-submitter: add error messages Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
) * feat: add config for impersonating accounts to BS Useful for testing against hardhat forks. * Make block offset configurable (ethereum-optimism#865) * feat: make block offset configurable * Add a USE_HARDHAT config * batch-submitter: must pass both impersonate options (ethereum-optimism#866) Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> * batch-submitter: update example env * batch-submitter: lint fix * batch-submitter: clean up old comments * batch-submitter: USE_HARDHAT * batch-submitter: add error messages Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* feat(client): Re-accelerate precompiles * fix: lint --------- Co-authored-by: refcell <abigger87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quickfix to the option parsing, require that both env vars are set when using the impersonate feature of hardhat