Skip to content

chore: update READMEs with new env vars#842

Merged
annieke merged 3 commits intodevelopfrom
annie/document-env-vars
May 12, 2021
Merged

chore: update READMEs with new env vars#842
annieke merged 3 commits intodevelopfrom
annie/document-env-vars

Conversation

@annieke
Copy link
Copy Markdown
Contributor

@annieke annieke commented May 11, 2021

Description
Document new env vars in typescript services from previous changes.

Metadata

  • Adds context for new variables and when Sentry is initialized

@annieke annieke requested a review from karlfloersch as a code owner May 11, 2021 21:10
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 11, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: c896b9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@annieke annieke requested a review from tynes May 11, 2021 21:11
smartcontracts
smartcontracts reviewed May 11, 2021
View reviewed changes
tynes
tynes reviewed May 11, 2021
View reviewed changes
@annieke annieke requested review from smartcontracts and tynes May 11, 2021 21:58
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2021

Codecov Report

Merging #842 (6e28a0e) into develop (52d9e6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #842   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d9e6b...6e28a0e. Read the comment docs.

@annieke annieke force-pushed the annie/document-env-vars branch from 6e28a0e to c896b9a Compare May 12, 2021 18:13
@annieke annieke merged commit 5ccf42e into develop May 12, 2021
@annieke annieke deleted the annie/document-env-vars branch May 12, 2021 19:08
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
@annieke
chore: update READMEs with new env vars (ethereum-optimism#842)
7a17f60 
* chore: update READMEs with new env vars

* extra context in dtl readme

* more context
theochap pushed a commit that referenced this pull request Dec 10, 2025
@refcell
feat(host): delete unused blob providers (#842)
da7beb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karlfloersch karlfloersch Awaiting requested review from karlfloersch

@tynes tynes Awaiting requested review from tynes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

1 more reviewer

@snario snario snario approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-op-batcher Area: op-batcher

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@annieke @codecov-commenter @snario @tynes @smartcontracts