fix(l2geth): do not throw an error when estimating gas for txs with nil data#940
fix(l2geth): do not throw an error when estimating gas for txs with nil data#940
Conversation
🦋 Changeset detectedLatest commit: f347c34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #940 +/- ##
========================================
Coverage 82.21% 82.21%
========================================
Files 48 48
Lines 1895 1895
Branches 303 303
========================================
Hits 1558 1558
Misses 337 337 Continue to review full report at Codecov.
|
| to: DEFAULT_TRANSACTION.to, | ||
| value: 0, | ||
| }) | ||
| expect(estimate).to.be.eq(21000) |
There was a problem hiding this comment.
Do transactions with empty data always return a gas estimate of 21000? Why? Can this be abused?
There was a problem hiding this comment.
This was implemented in #695, it's not unique to empty data txs
There was a problem hiding this comment.
The idea was to never let the value be lower than 21000 because that breaks an expectation that Metamask had. With #906 that line is removed
…il data (ethereum-optimism#940) * fix(l2geth): do not throw an error when estimating gas for txs with nil data * chore: add changeset
Fixes #930