Skip to content

relayer: logging cleanup#807

Merged
tynes merged 3 commits intomasterfrom
relayer/logging-cleanup
May 10, 2021
Merged

relayer: logging cleanup#807
tynes merged 3 commits intomasterfrom
relayer/logging-cleanup

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented May 7, 2021

Description
This PR removes the logging of the options at runtime. This is not safe because it contains secrets

@tynes tynes requested a review from K-Ho as a code owner May 7, 2021 19:33
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 7, 2021

🦋 Changeset detected

Latest commit: 180719b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2021

Codecov Report

Merging #807 (180719b) into master (67e153e) will increase coverage by 4.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   77.78%   82.21%   +4.43%     
==========================================
  Files          48       48              
  Lines        1886     1895       +9     
  Branches      297      303       +6     
==========================================
+ Hits         1467     1558      +91     
+ Misses        419      337      -82     
Impacted Files Coverage Δ
...ic-ethereum/OVM/execution/OVM_ExecutionManager.sol 74.51% <0.00%> (-0.49%) ⬇️
.../optimistic-ethereum/OVM/accounts/OVM_ProxyEOA.sol 0.00% <0.00%> (ø)
...ic-ethereum/OVM/bridge/tokens/OVM_L1ETHGateway.sol 100.00% <0.00%> (ø)
...ethereum/OVM/accounts/OVM_ECDSAContractAccount.sol 0.00% <0.00%> (ø)
...thereum/OVM/predeploys/OVM_SequencerEntrypoint.sol 0.00% <0.00%> (ø)
...libraries/wrappers/Lib_ExecutionManagerWrapper.sol 0.00% <0.00%> (ø)
...mistic-ethereum/libraries/utils/Lib_ECDSAUtils.sol
...timistic-ethereum/libraries/codec/Lib_EIP155Tx.sol 96.55% <0.00%> (ø)
...ptimistic-ethereum/libraries/rlp/Lib_RLPWriter.sol 94.02% <0.00%> (+0.18%) ⬆️
...imistic-ethereum/libraries/trie/Lib_MerkleTrie.sol 98.30% <0.00%> (+23.41%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e153e...180719b. Read the comment docs.

@tynes tynes added A-ts-packages C-chore Category: Code, docs or tooling maintenance labels May 7, 2021
@tynes tynes merged commit d723b2a into master May 10, 2021
@tynes tynes deleted the relayer/logging-cleanup branch May 10, 2021 22:32
smartcontracts pushed a commit that referenced this pull request May 11, 2021
* relayer: don't log options at startup

* chore: add changeset

* relayer: log specifc config options
smartcontracts added a commit that referenced this pull request May 12, 2021
* docs: add truffle example

* fix: add gasPrice: 0 to all ctc calls and deploys

* chore(truffle-example): use correct truffle command

* fix: install missing packages

* style: fix missing newlines

* fix: attempt to fix yarn.lock (2)

* Update integration.yml

* specify truffle config and network

* correctly specify path and version

* relayer: logging cleanup (#807)

* relayer: don't log options at startup

* chore: add changeset

* relayer: log specifc config options

* config: message relayer (#809)

* relayer: migrate towards prefixed config w/ backwards compat

* chore: update relayer config parsing

* env: use start-offset instead of block offset

* lint: fix

* deps: add bcfg

* message-relayer: cleaner config parsing

* lint: fix

* Version Packages (#833)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: geth miner timestamp bug (#836)

* l2geth: use correct timestamp protection

* chore: add changeset

* Version Packages (#837)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* style: require curly braces for if statements (#835)

* test[integration-tests]: l2geth call and creation OOG (#839)

* fix: WE DID IT

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: ben-chain <ben@pseudonym.party>
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* relayer: don't log options at startup

* chore: add changeset

* relayer: log specifc config options
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* docs: add truffle example

* fix: add gasPrice: 0 to all ctc calls and deploys

* chore(truffle-example): use correct truffle command

* fix: install missing packages

* style: fix missing newlines

* fix: attempt to fix yarn.lock (2)

* Update integration.yml

* specify truffle config and network

* correctly specify path and version

* relayer: logging cleanup (ethereum-optimism#807)

* relayer: don't log options at startup

* chore: add changeset

* relayer: log specifc config options

* config: message relayer (ethereum-optimism#809)

* relayer: migrate towards prefixed config w/ backwards compat

* chore: update relayer config parsing

* env: use start-offset instead of block offset

* lint: fix

* deps: add bcfg

* message-relayer: cleaner config parsing

* lint: fix

* Version Packages (ethereum-optimism#833)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: geth miner timestamp bug (ethereum-optimism#836)

* l2geth: use correct timestamp protection

* chore: add changeset

* Version Packages (ethereum-optimism#837)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* style: require curly braces for if statements (ethereum-optimism#835)

* test[integration-tests]: l2geth call and creation OOG (ethereum-optimism#839)

* fix: WE DID IT

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: ben-chain <ben@pseudonym.party>
theochap pushed a commit that referenced this pull request Dec 10, 2025
* fix: book workflow

* fix: pins mdbook version to 0.4.40
OptimismBot pushed a commit that referenced this pull request Jan 22, 2026
* feat: add skip protocol versions deployment when opcmv2 enabled

* feat: add protocol versions deprecation related scripts & tests

* feat: add revert cases when submitting non zero values for protocol versions and opcmv2 is enabled

* fix: superchain deployment in op deployer tests and script

* fix: set protocolVersionsOwner input to zero if v2 enabled in DeploySuperchain

* test: add tests for superchain script and pipeline

* test: refactor deploysuperchain scripts test

* fix: remove unnecessary protocolVersionsOwner var

* test: add protocol versions assertions in e2e apply test

* feat: add checks for bootstrap superchain

* feat: add op chain ops config for deploysuperchain

* fix: revert op chain ops config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-chore Category: Code, docs or tooling maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants