Skip to content

feat: update mainnet deployment#838

Merged
tynes merged 8 commits intodevelopfrom
feat/update_mainnet_deployment
May 12, 2021
Merged

feat: update mainnet deployment#838
tynes merged 8 commits intodevelopfrom
feat/update_mainnet_deployment

Conversation

@karlfloersch
Copy link
Copy Markdown
Contributor

@karlfloersch karlfloersch commented May 11, 2021

Description
Add a new mainnet deployment of v0.3.0.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 11, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 76ce630

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2021 •
edited
Loading

Codecov Report

Merging #838 (ebbe988) into develop (8d67991) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #838   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d67991...ebbe988. Read the comment docs.

@tynes
Copy link
Copy Markdown
Contributor

tynes commented May 11, 2021

Can you regenerate the README? This will be good to merge after that

smartcontracts
smartcontracts reviewed May 11, 2021
View reviewed changes
packages/contracts/deployments/mainnet/OVM_ChainStorageContainer:CTC:batches.json
@@ -0,0 +1,453 @@
{
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update colons in names to hypens

Copy link
Copy Markdown
Contributor Author

@karlfloersch karlfloersch May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah what is the context for that? I noticed they were hyphens in the old mainnet deploy but didn't know why we did that. I'll add a commit to fix that though

Copy link
Copy Markdown
Contributor Author

@karlfloersch karlfloersch May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the names of the files to use hyphens. Anything else that needs to change?

packages/contracts/deployments/mainnet/OVM_CanonicalTransactionChain.json
18000000,
1200000,
"0x668E5b997b9aE88a56cd40409119d4Db9e6d752E",
15769999,
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these weird config values?

Copy link
Copy Markdown
Contributor Author

@karlfloersch karlfloersch May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn thought I changed that to 15770000 which is ~half a year.

packages/contracts/deployments/mainnet/OVM_ExecutionManager.json Outdated
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we double check that there are no problems with 100k min

Copy link
Copy Markdown
Contributor Author

@karlfloersch karlfloersch May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ben-chain check me on this one, but I think that 100k should be fine considering we have this check in the deposits:

optimism/packages/contracts/contracts/optimistic-ethereum/OVM/chain/OVM_CanonicalTransactionChain.sol

Line 41 in 52d9e6b

uint256 constant public MIN_ROLLUP_TX_GAS = 100000;

Copy link
Copy Markdown
Collaborator

@ben-chain ben-chain May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, these should be combined and always kept the same. I agree that this is OK due to the current require that Karl pointed out. One note is it will make things OOG more often, though.

@tynes tynes mentioned this pull request May 11, 2021
Closed
@platocrat
Copy link
Copy Markdown
Contributor

platocrat commented May 12, 2021 •
edited
Loading

^we had to bring the branch up-to-date with develop again, so I went ahead and merged to do so.
Still needs a review

Update
GH says this branch is still out-of-date with develop.

@tynes
Copy link
Copy Markdown
Contributor

tynes commented May 12, 2021

Merging this because its high priority and there is no going back at this point. The config options are safe but we should consider discussing them in public more next time so that there can be more input

@tynes tynes merged commit 63f2cdd into develop May 12, 2021
@tynes tynes deleted the feat/update_mainnet_deployment branch May 12, 2021 17:29
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
@karlfloersch @gakonst
@tynes @platocrat
feat: update mainnet deployment (ethereum-optimism#838)
dcdc9fd 
* Update mainnet deployment

* Remove old unused contracts

* chore: regenerate readme

* Change : to - in deploy files

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: platocrat <37757724+platocrat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts left review comments

@ben-chain ben-chain Awaiting requested review from ben-chain

@maurelian maurelian Awaiting requested review from maurelian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@karlfloersch @codecov-commenter @tynes @platocrat @ben-chain @smartcontracts @gakonst