Skip to content

example: get revert msgs for hardhat#841

Merged
platocrat merged 5 commits intodevelopfrom
example/hardhat-get-revert-msgs
May 12, 2021
Merged

example: get revert msgs for hardhat#841
platocrat merged 5 commits intodevelopfrom
example/hardhat-get-revert-msgs

Conversation

@platocrat
Copy link
Copy Markdown
Contributor

@platocrat platocrat commented May 11, 2021

Description
Hardhat example was previously ignoring revert messages due to the UNPREDICTABLE_GAS_LIMIT error that was thrown when contract calls would revert.

This change retrieves revert messages from contract calls.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 11, 2021

⚠️ No Changeset found

Latest commit: 78e6f87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (a30817e) to head (78e6f87).
⚠️ Report is 26045 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop    #841   +/-   ##
=======================================
  Coverage     82.2%   82.2%           
=======================================
  Files           48      48           
  Lines         1895    1895           
  Branches       303     303           
=======================================
  Hits          1558    1558           
  Misses         337     337           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smartcontracts
Copy link
Copy Markdown
Contributor

LGTM. Feel free to merge once tests pass.

@platocrat platocrat merged commit e88e85d into develop May 12, 2021
@platocrat platocrat deleted the example/hardhat-get-revert-msgs branch May 12, 2021 16:11
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* example: get revert msgs for hardhat

* fix: remove chai-as-promised dep and logic

* re-add @types/mocha and @types/chai

* Update examples/hardhat/package.json

Co-authored-by: smartcontracts <kelvinfichter@gmail.com>
theochap pushed a commit that referenced this pull request Dec 10, 2025
Bumps [rustls](https://github.com/rustls/rustls) from 0.23.17 to 0.23.18.
- [Release notes](https://github.com/rustls/rustls/releases)
- [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md)
- [Commits](rustls/rustls@v/0.23.17...v/0.23.18)

---
updated-dependencies:
- dependency-name: rustls
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
OptimismBot pushed a commit that referenced this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants