Skip to content

fix: have workflows run on develop#845

Merged
karlfloersch merged 1 commit intodevelopfrom
kelvin/update-workflows-develop
May 12, 2021
Merged

fix: have workflows run on develop#845
karlfloersch merged 1 commit intodevelopfrom
kelvin/update-workflows-develop

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts commented May 11, 2021

Description
Fixes workflows so they'll execute correctly on develop.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 11, 2021

⚠️ No Changeset found

Latest commit: 4ea6c8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-ci label May 11, 2021
@smartcontracts smartcontracts marked this pull request as draft May 11, 2021 23:44
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2021

Codecov Report

Merging #845 (4ea6c8c) into develop (52d9e6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #845   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d9e6b...4ea6c8c. Read the comment docs.

@karlfloersch karlfloersch marked this pull request as ready for review May 12, 2021 02:31
karlfloersch
karlfloersch approved these changes May 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! The names of the 'required CI' changed at some point. My guess is that at some point either 1) we changed the name of our workflows, or 2) GH started using the name for its branch protections. (example blame: https://github.com/ethereum-optimism/optimism/blame/develop/.github/workflows/ts-packages.yml#L106-L107 )

Anyway this looks good and can be merged I believe

@karlfloersch
Copy link
Copy Markdown
Contributor

karlfloersch commented May 12, 2021 •
edited
Loading

Oh I changed the required checks also in our branch protections so that this PR would start passing CI

@karlfloersch karlfloersch merged commit 8d67991 into develop May 12, 2021
@karlfloersch karlfloersch deleted the kelvin/update-workflows-develop branch May 12, 2021 02:38
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
@smartcontracts
fix: have workflows run on develop (ethereum-optimism#845)
4c3aca9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karlfloersch karlfloersch karlfloersch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smartcontracts @codecov-commenter @karlfloersch