Skip to content

Update Github Actions for the develop branch#856

Merged
tynes merged 2 commits intodevelopfrom
bwilson/github-action-on-develop
May 12, 2021
Merged

Update Github Actions for the develop branch#856
tynes merged 2 commits intodevelopfrom
bwilson/github-action-on-develop

Conversation

@optimisticben
Copy link
Copy Markdown
Contributor

@optimisticben optimisticben commented May 12, 2021

Description
Now that develop is the default branch, we should generate packages from the branch for testing deployments.

Additional context
Added the develop branch to the workflows:

  • geth unit tests
  • integration
  • Release
  • typescript / contracts

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 12, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 316741f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-ci label May 12, 2021
@smartcontracts
Copy link
Copy Markdown
Contributor

smartcontracts commented May 12, 2021

@optimisticben I think you might've built this PR on top of an older version of develop. We updated some of these files last night so there are a few conflicts that need to be resolved.

@optimisticben optimisticben force-pushed the bwilson/github-action-on-develop branch from e5978b5 to 316741f Compare May 12, 2021 21:17
@optimisticben
Copy link
Copy Markdown
Contributor Author

optimisticben commented May 12, 2021

@optimisticben I think you might've built this PR on top of an older version of develop. We updated some of these files last night so there are a few conflicts that need to be resolved.

Thanks! Updated.

@tynes tynes merged commit 7d8d294 into develop May 12, 2021
@tynes tynes deleted the bwilson/github-action-on-develop branch May 12, 2021 21:41
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
@optimisticben
Update Github Actions for the develop branch (ethereum-optimism#856)
441b74e 
* Update Github Actions for the develop branch

* Rebased and updated changeset config
theochap pushed a commit that referenced this pull request Dec 10, 2025
@refcell
chore: Bump Other Dependencies (#856)
c678bee 
* fix: bump

* fix: bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@snario snario Awaiting requested review from snario

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

@gakonst gakonst Awaiting requested review from gakonst

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@optimisticben @smartcontracts @tynes