⚠️ No Changeset found

Latest commit: 7846ad0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Codecov Report

Merging #944 (7846ad0) into develop (4e6c3f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #944   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6c3f9...7846ad0. Read the comment docs.

This file is autogenerated so it should not be edited manually. If you want to change it, you need to update the script that generates it

Script here: https://github.com/ethereum-optimism/optimism/blob/develop/packages/contracts/scripts/generate-markdown.js

woops, didn't mean to close this

I think we're good now

Hmmm. I think the following might be a bit easier to follow:

1. Put the proxies back in the primary list
2. Remove the implementation contracts from the primary list
3. Put the implementation contracts inside of an html comment in the markdown so we can still see them but they aren't displayed publicly, like:

<!--
Implementation addresses. DO NOT use these addresses directly. Use their proxied counterparts seen above.

... addresses go here
-->