Conversation
🦋 Changeset detectedLatest commit: 2989f38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #939 +/- ##
========================================
Coverage 82.21% 82.21%
========================================
Files 48 48
Lines 1895 1895
Branches 303 303
========================================
Hits 1558 1558
Misses 337 337 Continue to review full report at Codecov.
|
gakonst
approved these changes
May 23, 2021
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
…ents that run out of gas (ethereum-optimism#939) * test: add deploy OOG test and improve OOG error message * chore: add changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an integration test for contract deployments that run out of gas. Also updates the returned error message to be more clear, following the same pattern that upstream geth uses: https://github.com/ethereum/go-ethereum/blob/154ca32a8ade0a7d2461d0eb432361261a51a395/internal/ethapi/api.go#L1061
Metadata