Merged
Conversation
🦋 Changeset detectedLatest commit: 88d1b6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
33cffda to
ec911e5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #880 +/- ##
========================================
Coverage 82.21% 82.21%
========================================
Files 48 48
Lines 1895 1895
Branches 303 303
========================================
Hits 1558 1558
Misses 337 337
Continue to review full report at Codecov.
|
maurelian
approved these changes
May 14, 2021
ec911e5 to
88d1b6c
Compare
Contributor
|
Ugh, rebased locally like a good guy, now I have to wait for the checks. |
Contributor
|
FWIW this kind of PR does not need a changeset |
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
OptimismBot
pushed a commit
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This comment is:
optimism/packages/contracts/contracts/optimistic-ethereum/OVM/accounts/OVM_ECDSAContractAccount.sol
Line 103 in cb2e9ad
optimism/packages/contracts/contracts/optimistic-ethereum/libraries/codec/Lib_EIP155Tx.sol
Lines 97 to 98 in cb2e9ad
So I just deleted it.