Conversation
🦋 Changeset detectedLatest commit: 1a45645 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #847 +/- ##
========================================
Coverage 82.21% 82.21%
========================================
Files 48 48
Lines 1895 1895
Branches 303 303
========================================
Hits 1558 1558
Misses 337 337 Continue to review full report at Codecov.
|
annieke
left a comment
There was a problem hiding this comment.
this change overall looks good to me, can we update .env.example to the new format?
There was a problem hiding this comment.
to confirm, this is the only new variable added / changed in this PR?
There was a problem hiding this comment.
Yes this is the only new variable added - it is used to be explicit and we should make sure that we use the same name across the different services
There was a problem hiding this comment.
@tynes this defaults to false then i'm assuming? would appreciate adding this to .env.example!
This is backwards compatible, with updating |
To follow up @annieke, I do not plan on updating the example env until the backwards compatibility is removed and we fully use the scheme of prefixed env vars. Right now the example env is acting as a forcing function for backwards compatibility |
There was a problem hiding this comment.
@tynes this defaults to false then i'm assuming? would appreciate adding this to .env.example!
|
I've also added a changeset for the other impacted packages |
* batch-submitter: backwards compatible configuration * chore: add changeset * deps: update * js: move bcfg interface to core-utils * batch-submitter: parse USE_SENTRY and add to env example * chore: add changeset * batch-submitter: parse as float instead of int * batch-submitter: better error logging
* batch-submitter: backwards compatible configuration * chore: add changeset * deps: update * js: move bcfg interface to core-utils * batch-submitter: parse USE_SENTRY and add to env example * chore: add changeset * batch-submitter: parse as float instead of int * batch-submitter: better error logging
…552) * l2geth: add Backend enums and config parsing * l2geth: move OVMContext to types file * l2geth: implement syncservice spec * l2geth: fix error handling for get tx batch * l2geth: update tests to compile and pass * l2geth: add sync range functions * l2geth: add batch index indexing * l2geth: update syncservice hot path logging * l2geth: use indexed batch index * chore: add changeset * l2geth: sync spec refactor (#822) * l2geth: more in depth usage string * l2geth: add standard client getters for index * l2geth: refactor sync service into shared codepaths * l2geth: clean up tests * l2geth: better logging and error handling * test: improve test coverage around timestamps * l2geth: improve docstring * l2geth: rename variable * sync-service: better logline * l2geth: better logline * l2geth: test apply indexed transaction * l2geth: better logline * linting: fix * syncservice: fix logline * l2geth: add error and fix logline * l2geth: sync service tests * fix: get last confirmed enqueue (#846) * l2geth: fix get last confirmed enqueue * chore: add changeset * client: return error correctly * batch-submitter: updated config (#847) * batch-submitter: backwards compatible configuration * chore: add changeset * deps: update * js: move bcfg interface to core-utils * batch-submitter: parse USE_SENTRY and add to env example * chore: add changeset * batch-submitter: parse as float instead of int * batch-submitter: better error logging * l2geth: update rawdb logline Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * l2geth: more robust testing Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> * l2geth: add sanity check for L1ToL2 timestamps * l2geth: handle error in single place * l2geth: fix test tx queue origin * l2geth: add new arg to start.sh * l2geth: return error in the SyncService.Start() * chore: go fmt Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Description
Updates the config in a backwards compatible way so that it works with
bcfg. Now the prefixBATCH_SUBMITTER_<config-name>will be parsed as config as well as CLI arguments. This was done in a backwards compatible way such that the previous env vars are parsed as the default values. We can move towards phasing out the old configuration style in the future.Also uses the
USE_SENTRYconfig option to turn on sentry