Skip to content

feat[smock]: add a wallet that be used to send transactions from a smock#896

Merged
smartcontracts merged 9 commits intodevelopfrom
kelvin/send-from-smocks
May 18, 2021
Merged

feat[smock]: add a wallet that be used to send transactions from a smock#896
smartcontracts merged 9 commits intodevelopfrom
kelvin/send-from-smocks

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Description
Was working on this for fun over the weekend. Adds a wallet to every smock that can be used to send transactions from the smock account.

@smartcontracts smartcontracts requested a review from maurelian as a code owner May 17, 2021 21:29
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 17, 2021

🦋 Changeset detected

Latest commit: 14639d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/smock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smartcontracts smartcontracts changed the title Kelvin/send from smocks feat[smock]: add a wallet that be used to send transactions from a smock May 17, 2021
Copy link
Copy Markdown
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I did make one small suggested change.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #896 (14639d8) into develop (9fea7c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #896   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d352de...14639d8. Read the comment docs.

@smartcontracts smartcontracts merged commit a656f06 into develop May 18, 2021
@smartcontracts smartcontracts deleted the kelvin/send-from-smocks branch May 18, 2021 20:58
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
…ock (ethereum-optimism#896)

* feat[smock]: add support for sending txs from mocks

* fix: remove unused imports

* chore: add changeset

* fix: readme errors

* Update packages/smock/README.md

* Update packages/smock/README.md

Co-authored-by: Maurelian <maurelian@protonmail.ch>

Co-authored-by: Maurelian <maurelian@protonmail.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants