Skip to content

fix(l2geth): add an env var METRICS_ENABLE for MetricsEnabledFlag#934

Merged
tynes merged 1 commit intoethereum-optimism:developfrom
timmyers:metrics-flag
May 25, 2021
Merged

fix(l2geth): add an env var METRICS_ENABLE for MetricsEnabledFlag#934
tynes merged 1 commit intoethereum-optimism:developfrom
timmyers:metrics-flag

Conversation

@timmyers
Copy link
Copy Markdown
Contributor

Description
Adds an env var METRICS_ENABLE for the MetricsEnabledFlag CLI arg.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 21, 2021

🦋 Changeset detected

Latest commit: 0ce4cc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@timmyers timmyers changed the title feat: add an env var METRICS_ENABLE for MetricsEnabledFlag fix: add an env var METRICS_ENABLE for MetricsEnabledFlag May 21, 2021
@timmyers timmyers marked this pull request as ready for review May 21, 2021 17:45
@timmyers timmyers changed the title fix: add an env var METRICS_ENABLE for MetricsEnabledFlag fix(l2geth): add an env var METRICS_ENABLE for MetricsEnabledFlag May 21, 2021
@tynes
Copy link
Copy Markdown
Contributor

tynes commented May 21, 2021

Thanks for the PR @timmyers! Will merge this. Wondering your thoughts on using environment variables vs CLI flags for configuration - we are considering the removal of env var based configuration when we migrate to using the latest version of go-ethereum as to reduce the diff as much as possible

@timmyers
Copy link
Copy Markdown
Contributor Author

I prefer env vars, I find them to be the cleanest, especially when defining (kubernetes) manifests as code.
It would be great if we could make some effort to upstream env var support into geth.

@tynes
Copy link
Copy Markdown
Contributor

tynes commented May 24, 2021

I prefer env vars, I find them to be the cleanest, especially when defining (kubernetes) manifests as code.
It would be great if we could make some effort to upstream env var support into geth.

This has been suggested upstream before ethereum/go-ethereum#14346

@tynes tynes merged commit 4e6c3f9 into ethereum-optimism:develop May 25, 2021
@timmyers timmyers deleted the metrics-flag branch May 25, 2021 15:08
@timmyers
Copy link
Copy Markdown
Contributor Author

Ah I see. Well CLI args are definitely workable if at some point you want to remove them to slim the diff. The config file option is by far the worst to work with for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants