fix[batch-submitter]: read metrics env vars correctly#890
Conversation
|
|
Do you mind adding a changeset so that we can publish a new release including this? |
There was a problem hiding this comment.
Can we rename prometheus-port -> metrics-port and prometheus-hostname -> metrics-address?
Should these env name be separated by package? Something like BATCHSUBMITTER_METRICS_PORT and BATCHSUBMITTER_METRICS_ADDRESS?
There was a problem hiding this comment.
The prefix BATCH_SUBMITTER is supported based on this line here:
A library called bcfg is used for env var parsing. It is lightweight, simple and has no dependencies besides the JS std library. It parses prefixed env vars, CLI args and can read from a config file at ~$HOME/.<name-passed-to-config>/* with the config.open function - https://github.com/bcoin-org/bcfg/blob/1216c775832c2e138ae6451912a27ba496dc4386/lib/config.js#L128
There was a problem hiding this comment.
This still doesn't address the change to metrics-*
172a8bd to
fae9a05
Compare
…ism#890) * fix[batch-submitter]: read metrics env vars correctly * rename to metrics
Description
Fixes reading the default prom server env vars before we switch over to fully using bcfg.
Additional context
unblocks @optimisticben !
Metadata