Skip to content

maintenance: standardize license usage#861

Merged
smartcontracts merged 4 commits intodevelopfrom
kelvin/update-licenses
May 13, 2021
Merged

maintenance: standardize license usage#861
smartcontracts merged 4 commits intodevelopfrom
kelvin/update-licenses

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Description
Standardizes usage of our MIT license so that we:

  1. Have a copy of our license within each sub-package
  2. Use the correct author name and license in all package.json files.

Metadata

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 13, 2021

⚠️ No Changeset found

Latest commit: cd40b75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-contracts A-op-batcher Area: op-batcher A-pkg-core-utils Area: packages/core-utils labels May 13, 2021
@tynes
Copy link
Copy Markdown
Contributor

tynes commented May 13, 2021

Can you rename all of the LICENSE.txts to just LICENSE? This is usually how projects do it

Copy link
Copy Markdown
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename and i'll approve

@smartcontracts
Copy link
Copy Markdown
Contributor Author

Can you rename all of the LICENSE.txts to just LICENSE? This is usually how projects do it

Problem with just LICENSE is that files without an extension often don't display correctly on windows. I'm pretty sure windows file explorer doesn't display these files at all without some extra effort. Plenty of projects use the .txt extension, don't think it makes a huge difference.

@smartcontracts
Copy link
Copy Markdown
Contributor Author

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #861 (cd40b75) into develop (96a586e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #861   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a586e...cd40b75. Read the comment docs.

@smartcontracts smartcontracts merged commit 0d1ed67 into develop May 13, 2021
@smartcontracts smartcontracts deleted the kelvin/update-licenses branch May 13, 2021 18:14
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* maintenance: standardize license usage

* fix: rename LICENSE.txt to LICENSE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-batcher Area: op-batcher A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate LICENSE.txt within all packages

3 participants