Skip to content

Fix HexaPDF dependency#13834

Merged
andreslucena merged 4 commits intodevelopfrom
chore/dependencies/hexapdf
Jan 13, 2025
Merged

Fix HexaPDF dependency#13834
andreslucena merged 4 commits intodevelopfrom
chore/dependencies/hexapdf

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Jan 11, 2025

🎩 What? Why?

Back in #13617, i have added a requirement of hexapdf to the core in Decidim::Exporters::Pdf which is used by Decidim::Exporters::FormPDF which is shipped by decidim-forms module. Yet, this module is a further dependency to meetings, surveys and other decidim modules.

This PR adds to a hexapdf gem requirement to decidim-core, so that we ensure no matter what module that requires hexapdf to be installed, is taken care of.

📌 Related Issues

Link your PR to an issue

Testing

  1. Pipeline is green

♥️ Thank you!

@github-actions github-actions bot added module: core dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: generators module: initiatives type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jan 11, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 11, 2025
@alecslupu alecslupu marked this pull request as ready for review January 13, 2025 09:08
andreslucena
andreslucena previously approved these changes Jan 13, 2025
@andreslucena
Copy link
Copy Markdown
Member

@alecslupu there are git conflicts here, can you check them out 🙏🏽 ?

github-actions[bot]
github-actions bot previously approved these changes Jan 13, 2025
@andreslucena andreslucena merged commit 9d8cd57 into develop Jan 13, 2025
@andreslucena andreslucena deleted the chore/dependencies/hexapdf branch January 13, 2025 14:52
entantoencuanto added a commit that referenced this pull request Jan 14, 2025
* develop: (27 commits)
  WCAG navigation submenu (#13796)
  Update gem dependencies (part 3) (#13849)
  Prevent notifications for deleted users (#13812)
  Retries NPM installation a couple times to prevent network timeouts (#13831)
  Update gem dependencies (part 2) (#13839)
  Enhance signature pdf export (#13778)
  Fix HexaPDF dependency (#13834)
  Fix flaky spec in authentication (#13827)
  Merge upload field for documents and image on proposal admin form (#13735)
  Update gem dependencies (#13835)
  Upgrade erb_lint to 0.8.0 (#13833)
  Fix flaky spec in geocoder (#13820)
  Refactor modules mounting routes (#13294)
  Upgrade check-spelling action (#13825)
  Add missing images in the custom registration emails from meetings (#13632)
  Add missing translations (#13793)
  Fix proposal map performance with hundreds of markers (#13798)
  Create multiple surveys within same Survey component (#13420)
  Accountability bulk actions (#13730)
  Improve UI for sorting options on comments (#13670)
  ...
rsdeus pushed a commit to octree-gva/decidim that referenced this pull request Jan 15, 2025
* Fix HexaPDF dependency

* Fix Gemfile
antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025
* Fix HexaPDF dependency

* Fix Gemfile
andreslucena pushed a commit that referenced this pull request Mar 3, 2025
* Fix HexaPDF dependency

* Fix Gemfile
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
* Fix HexaPDF dependency

* Fix Gemfile
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
* Fix HexaPDF dependency

* Fix Gemfile
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
* Fix HexaPDF dependency

* Fix Gemfile
fblupi added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request May 8, 2025
…ows features (#46)

* Improve registration and verification flow (decidim#13295)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scopes_select_field from dummy authorization form

* Fix admin pipeline with `welcome_notification_body` spec error (decidim#14475)

* Standardize direct verification for one-time participation (decidim#13579)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scope from tests

* Make transferable authorization when duplicate user is ephemeral (decidim#13981)

* Implement share and download buttons in budget successful vote screen (decidim#14283)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Extract success animation to a helper

* Fix HexaPDF dependency (decidim#13834)

* Fix HexaPDF dependency

* Fix Gemfile

* Remove reference to rqrcode

* Update decidim-generators lockfile

* Implement focus mode in the budget projects component (decidim#14512)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Allow customization of focus_mode_back_button text and path and use in projects index

* Define a setting in budgets component to enter in focus mode by default voting budgets

* Hide start voting button if voting is not available

* Hide voting progress box in project show if not in focus mode

* Consider focus mode settings in budgets lists cells

* Adapt tests

* Do not display vote text in budget list item cell if voting is not available

* Set authorization_redirect_path of project vote button to take into account focus mode

* Avoid duplication of button id

* Allow displaying close focus mode or ephemeral session on header with focus mode back button

* Adapt tests

* Add missing i18n strings from ca/es (#49)

* Use focus mode and Vote text regardless the allowed vote status

* Define budget order status view in focus mode

* Redirect to focus mode endpoints when component settings sets focus mode as default

* Fix linter offense

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Remove unused translations

* Fix tests

* Add new strings for the budgets voting phase

* Remove 'Download your vote' from the success page in Budgets

* Fix size in project's title

* Remove unused strings

* Change bold messages in the budget's voting explanation

* Change behavior of the minimum budget so it's minimum projects

* Redirect authorized vote button in projects index to the same page

* Exclude focus navigation links from exit focus warning modal behavior

* Normalize i18n on English locale and make consistent the other translations

* Fix budget detail with "You voted for this" string (decidim#14284)

* Adapt tests

* Add highlighted colors on the different states of the budgets' voting (#55)

* Add highlighted colors on the different states of the budgets' voting

* Improve the message in the finished budget voting

* Fix linter offense

* Remove share button and fix header close button (#56)

* Remove share button and center CTA

* Add title to success page

* Fix placing of the Cancel button in ephemeral/focus modes

* Remove unused strings from i18n-tasks

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@gmail.com>
Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: core module: generators module: initiatives type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants