Conversation
ae44b66 to
e36bd9f
Compare
There was a problem hiding this comment.
Hello, @mllocs wonderful job 💯
Here is my review with a couple of things:
- When I change the status of various results using the bulk action button
Then the status is changed, but the progress does not.
The expected behavior is that if a change the status, then the percentage of progress should be modified, according to what is defined in the results statuses.
See where admins defines this relation between statuses and % progress: https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/1/manage/statuses
- When I change the taxonomy using bulk actions,
If a result has one taxonomy already defined (Category: Illiam..)
And I just want to add a new taxonomy (City Districts: Sant Martí)
Then, the category is removed and only prevails the city district.
My expectation would be to respect the already defined taxonomy (Category: Illiam..) , and add the new taxonomy (City Districts: Sant Martí).
20f8f22
Mmm... This is very tricky. If you select one element, you know for certain which Taxonomy A and B the item might have. In that case, we can prepopulate the corresponding select with the option, so you are aware of the result. But, what about if you select various items with different values for any of the taxonomies? We could not select an option. Only thing we might do is to include some note in the corresponding filter such as: "Items currently have different classifications for this taxonomy. If you update it, the new value will be applied to all". And we might think on a way to improve the predictability by the user that "choosing" the value "Please select an option" will actually remove the value:
But this I think belongs to taxonomies, not this issue specifically. |
@NilHomedes Fixed this. Also we had an offline conversation around the bulk actions in Taxonomies. We decided for now to leave it as it works in proposals' bulk actions. |
NilHomedes
left a comment
There was a problem hiding this comment.
Working smoothly now @mllocs, great job! 🚀
|
Just for the record: We agreed to keep the current behavior when changing taxonomies using bulk actions. As this change is out of the scope of this issue. So now it works like this:
In the future, we should review this behavior and think a solution to avoid this unexpected behavior.
|
|
@mllocs you have a failing pipeline, and please assign it to me after it passes the Contractor review state. |
|
@alecslupu ready! :) |
There was a problem hiding this comment.
Almost perfect. The PR works as intended, yet, i do feel the need to add at least one system test.
Could you add one or more specs that would fulfill the following test scenario: "Given i have a bunch of results, when i click select all / select single, and click on actions, ... i can set the dates / status etc "
you could have a look here:
- decidim-proposals/spec/shared/split_proposals_examples.rb
- decidim-proposals/spec/shared/manage_proposals_taxonomies_examples.rb ( for the taxonomies specs )
35 / 35
2231b90
* develop: (27 commits) WCAG navigation submenu (#13796) Update gem dependencies (part 3) (#13849) Prevent notifications for deleted users (#13812) Retries NPM installation a couple times to prevent network timeouts (#13831) Update gem dependencies (part 2) (#13839) Enhance signature pdf export (#13778) Fix HexaPDF dependency (#13834) Fix flaky spec in authentication (#13827) Merge upload field for documents and image on proposal admin form (#13735) Update gem dependencies (#13835) Upgrade erb_lint to 0.8.0 (#13833) Fix flaky spec in geocoder (#13820) Refactor modules mounting routes (#13294) Upgrade check-spelling action (#13825) Add missing images in the custom registration emails from meetings (#13632) Add missing translations (#13793) Fix proposal map performance with hundreds of markers (#13798) Create multiple surveys within same Survey component (#13420) Accountability bulk actions (#13730) Improve UI for sorting options on comments (#13670) ...
🎩 What? Why?
Add bulk actions in the Accountability component to:
📌 Related Issues
Testing
📷 Screenshots