Merged
Conversation
alecslupu
approved these changes
Jan 14, 2025
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
visiting using Voiceover the menu, i get:
"What is a participatory process", Visited link navigation menu "What is a participatory process?" navigation landmark
LGTM
This was referenced Jan 14, 2025
entantoencuanto
added a commit
that referenced
this pull request
Jan 14, 2025
* develop: (27 commits) WCAG navigation submenu (#13796) Update gem dependencies (part 3) (#13849) Prevent notifications for deleted users (#13812) Retries NPM installation a couple times to prevent network timeouts (#13831) Update gem dependencies (part 2) (#13839) Enhance signature pdf export (#13778) Fix HexaPDF dependency (#13834) Fix flaky spec in authentication (#13827) Merge upload field for documents and image on proposal admin form (#13735) Update gem dependencies (#13835) Upgrade erb_lint to 0.8.0 (#13833) Fix flaky spec in geocoder (#13820) Refactor modules mounting routes (#13294) Upgrade check-spelling action (#13825) Add missing images in the custom registration emails from meetings (#13632) Add missing translations (#13793) Fix proposal map performance with hundreds of markers (#13798) Create multiple surveys within same Survey component (#13420) Accountability bulk actions (#13730) Improve UI for sorting options on comments (#13670) ...
rsdeus
pushed a commit
to octree-gva/decidim
that referenced
this pull request
Jan 15, 2025
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
andreslucena
pushed a commit
that referenced
this pull request
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What?
This PR updates the submenu navigation structure to improve accessibility and ensure compliance with WCAG standards. Changes include:
aria-labelattribute dynamically generated using the current page title, to provide an accessible and descriptive name for the navigation zone.🎩 Why?
This issue originates from an accessibility audit funded by the city of Lyon, targeting compliance with RGAA and corresponding WCAG standards. The changes ensure clearer navigation and improved usability for assistive technologies.
📌 Related Issues
Related to WCAG 1.3.1 - Info and Relationships.
📋 Subtasks
CHANGELOGentry.Testing
Accessibility Check:
<nav>element.role="navigation"attribute is present.aria-labelcontains the appropriate value based on the current page title.Screen Reader Validation:
<h1>.📷 Screenshots