Fix proposal map performance with hundreds of markers#13798
Merged
andreslucena merged 7 commits intodevelopfrom Jan 9, 2025
Merged
Fix proposal map performance with hundreds of markers#13798andreslucena merged 7 commits intodevelopfrom
andreslucena merged 7 commits intodevelopfrom
Conversation
Merged
Member
|
I added the instructions on the Testing section with what I've done for confirming the performance issue |
andreslucena
reviewed
Jan 7, 2025
andreslucena
approved these changes
Jan 7, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
I only have the doubt about the meetings change, but apart from that it works as it should: only showing the first 25 proposals (from the pagination), as it works in Meetings directory and component.
This is the difference in my machine. I'm discarding the first request (as the shakapacker cache needs to be rebuilt). This is with 395 proposals.
Before
$ time curl -o /dev/null -s http://localhost:3000/processes/fruit-plain/f/7/proposals
________________________________________________________
Executed in 18.02 secs fish external
usr time 5.50 millis 2.24 millis 3.26 millis
sys time 8.54 millis 1.60 millis 6.95 millis
$ tme curl -o /dev/null -s http://localhost:3000/processes/fruit-plain/f/7/proposals
________________________________________________________
Executed in 21.09 secs fish external
usr time 6.37 millis 2.36 millis 4.01 millis
sys time 6.54 millis 1.18 millis 5.36 millis
$ tme curl -o /dev/null -s http://localhost:3000/processes/fruit-plain/f/7/proposals
________________________________________________________
Executed in 18.99 secs fish external
usr time 6.08 millis 1.80 millis 4.28 millis
sys time 5.16 millis 0.00 millis 5.16 millisAfter
$ time curl -o /dev/null -s http://localhost:3000/processes/fruit-plain/f/7/proposals
________________________________________________________
Executed in 3.33 secs fish external
usr time 5.17 millis 3.38 millis 1.79 millis
sys time 7.62 millis 0.20 millis 7.42 millis
$ time curl -o /dev/null -s http://localhost:3000/processes/fruit-plain/f/7/proposals
________________________________________________________
Executed in 3.12 secs fish external
usr time 1.25 millis 0.14 millis 1.11 millis
sys time 9.18 millis 2.58 millis 6.61 millis
$ time curl -o /dev/null -s http://localhost:3000/processes/fruit-plain/f/7/proposals
________________________________________________________
Executed in 3.04 secs fish external
usr time 5.19 millis 3.33 millis 1.85 millisSo, without a doubt, an improvement for sure. I only have the doubt that I'm mentioning about the meetings change and this can be merged.
andreslucena
requested changes
Jan 8, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
Changing my review until my last comment is actioned: #13798 (comment)
This reverts commit ea977f2.
andreslucena
approved these changes
Jan 9, 2025
This was referenced Jan 9, 2025
entantoencuanto
added a commit
that referenced
this pull request
Jan 14, 2025
* develop: (27 commits) WCAG navigation submenu (#13796) Update gem dependencies (part 3) (#13849) Prevent notifications for deleted users (#13812) Retries NPM installation a couple times to prevent network timeouts (#13831) Update gem dependencies (part 2) (#13839) Enhance signature pdf export (#13778) Fix HexaPDF dependency (#13834) Fix flaky spec in authentication (#13827) Merge upload field for documents and image on proposal admin form (#13735) Update gem dependencies (#13835) Upgrade erb_lint to 0.8.0 (#13833) Fix flaky spec in geocoder (#13820) Refactor modules mounting routes (#13294) Upgrade check-spelling action (#13825) Add missing images in the custom registration emails from meetings (#13632) Add missing translations (#13793) Fix proposal map performance with hundreds of markers (#13798) Create multiple surveys within same Survey component (#13420) Accountability bulk actions (#13730) Improve UI for sorting options on comments (#13670) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
During the maintainers meeting, we decided to fix some performance issues in the proposals controller. As a result we need to implement some changes in proposals controller.
In this PR, we change the way the proposals are displayed on the map. Initially we had all the proposals in the component rendered, and now we only display on the map the proposals listed in the current page.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
