Merged
Conversation
…ification_attachment
…moted.follower.email_subject
…moted.follower.email_intro
…moted.follower.email_outro
…ory_text.document
Member
|
@alecslupu feel free to send this to me when it's ready (and also filling the "Testing" section, because to be honest I don't know how to start looking into this) |
Contributor
Author
To be honest, you do not have a very good way of testing this against develop. https://github.com/decidim/decidim/actions/runs/12520054205/job/34925200753?pr=13267 and is fixed in 17c08bf |
andreslucena
reviewed
Jan 9, 2025
andreslucena
reviewed
Jan 9, 2025
andreslucena
reviewed
Jan 9, 2025
andreslucena
requested changes
Jan 9, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
Can you check my suggestions please? Thanks!
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
approved these changes
Jan 9, 2025
entantoencuanto
added a commit
that referenced
this pull request
Jan 14, 2025
* develop: (27 commits) WCAG navigation submenu (#13796) Update gem dependencies (part 3) (#13849) Prevent notifications for deleted users (#13812) Retries NPM installation a couple times to prevent network timeouts (#13831) Update gem dependencies (part 2) (#13839) Enhance signature pdf export (#13778) Fix HexaPDF dependency (#13834) Fix flaky spec in authentication (#13827) Merge upload field for documents and image on proposal admin form (#13735) Update gem dependencies (#13835) Upgrade erb_lint to 0.8.0 (#13833) Fix flaky spec in geocoder (#13820) Refactor modules mounting routes (#13294) Upgrade check-spelling action (#13825) Add missing images in the custom registration emails from meetings (#13632) Add missing translations (#13793) Fix proposal map performance with hundreds of markers (#13798) Create multiple surveys within same Survey component (#13420) Accountability bulk actions (#13730) Improve UI for sorting options on comments (#13670) ...
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
* Add missing activemodel.attributes.editor_image.file * Add missing strings * Fix: Translation missing: en.activemodel.attributes.user.avatar * Fix: Translation missing: en.activemodel.attributes.authorization.verification_attachment * Fix: Translation missing: en.activemodel.attributes.attachment.documents * Fix: Translation missing: en.activemodel.attributes.user_group.avatar * Fix: Translation missing: en.decidim.notifications_digest_mailer.header.real_time * Fix: Translation missing: en.activemodel.attributes.dummy_attribute * Fix: Translation missing: en.activemodel.attributes.dummy.image * Fix: Translation missing: en.activemodel.attributes.proposal.latitude * Fix: Translation missing: en.activemodel.attributes.proposal.longitude * Fix: Translation missing: en.decidim.notifications_digest_mailer.intro.real_time * Fix: Translation missing: en.decidim.events.amendments.emendation_promoted.follower.email_subject * Fix: Translation missing: en.decidim.events.amendments.emendation_promoted.follower.email_intro * Fix: Translation missing: en.decidim.events.amendments.emendation_promoted.follower.email_outro * Fix: Translation missing: en.decidim.metrics.blocked_users.description * Fix: Translation missing: en.activemodel.attributes.content_block_attachment.background_image * Fix: Translation missing: en.decidim.metrics.user_reports.description * Fix: Translation missing: en.decidim.metrics.reported_users.description * Fix: Translation missing: en.activemodel.attributes.import.file * Fix: Translation missing: en.activemodel.attributes.participatory_space_private_user_csv_import.file * Fix: Translation missing: en.decidim.admin_log.participatory_process_group.unpublish * Fix: Translation missing: en.activemodel.attributes.partner.logo * Fix: Translation missing: en.activemodel.attributes.proposals_file_import.file * Fix: Translation missing: en.activemodel.attributes.import_participatory_text.document * Fix: Translation missing: en.activemodel.attributes.answer.add_documents * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
added a commit
that referenced
this pull request
Mar 3, 2025
* Add missing activemodel.attributes.editor_image.file * Add missing strings * Fix: Translation missing: en.activemodel.attributes.user.avatar * Fix: Translation missing: en.activemodel.attributes.authorization.verification_attachment * Fix: Translation missing: en.activemodel.attributes.attachment.documents * Fix: Translation missing: en.activemodel.attributes.user_group.avatar * Fix: Translation missing: en.decidim.notifications_digest_mailer.header.real_time * Fix: Translation missing: en.activemodel.attributes.dummy_attribute * Fix: Translation missing: en.activemodel.attributes.dummy.image * Fix: Translation missing: en.activemodel.attributes.proposal.latitude * Fix: Translation missing: en.activemodel.attributes.proposal.longitude * Fix: Translation missing: en.decidim.notifications_digest_mailer.intro.real_time * Fix: Translation missing: en.decidim.events.amendments.emendation_promoted.follower.email_subject * Fix: Translation missing: en.decidim.events.amendments.emendation_promoted.follower.email_intro * Fix: Translation missing: en.decidim.events.amendments.emendation_promoted.follower.email_outro * Fix: Translation missing: en.decidim.metrics.blocked_users.description * Fix: Translation missing: en.activemodel.attributes.content_block_attachment.background_image * Fix: Translation missing: en.decidim.metrics.user_reports.description * Fix: Translation missing: en.decidim.metrics.reported_users.description * Fix: Translation missing: en.activemodel.attributes.import.file * Fix: Translation missing: en.activemodel.attributes.participatory_space_private_user_csv_import.file * Fix: Translation missing: en.decidim.admin_log.participatory_process_group.unpublish * Fix: Translation missing: en.activemodel.attributes.partner.logo * Fix: Translation missing: en.activemodel.attributes.proposals_file_import.file * Fix: Translation missing: en.activemodel.attributes.import_participatory_text.document * Fix: Translation missing: en.activemodel.attributes.answer.add_documents * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This was referenced Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While working on #13267, i have noticed there are a lot of missing translations that needs to be added to get a green pipeline.
I am adding it as a stand alone PR, to make it easier to be reviewed.
📌 Related Issues
Link your PR to an issue
Testing
This PR is actually tested by #13267.
I just had to run the pipeline, identify missing strings reported by failing specs, then just add them to pipeline.
I just extracted it a separate PR to ease up the review of #13267