Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@NilHomedes sending it to you, @furilo already sent me feedback in another channel. |
Please let's do the feedback in the same place, if not it's really difficult to manage a project with too many actors. |
There was a problem hiding this comment.
Hi @mllocs and happy new year!
Everything is working as expected, just a thing:
- The PDF export file is showing empty columns. So, as defined in the AC, if we are not collecting personal data, then the columns: Name and surname, Document number, Date of birth, Postal code. Should not be displayed in the export file.
Hey @NilHomedes! Happy new year! Yep, noticed that. The thing is that depending on the Initiative Type, the admin decides if these fields are collected or not (See "Collect participant personal data on signature" in https://decidim-lot2.populate.tools/admin/initiatives_types/1/edit). I'm showing the columns or not depending on that setting, the thing is that those fields are not mandatory and can still be empty... |
There was a problem hiding this comment.
Hey @mllocs, I disabled the setting "Collect personal data", and now the PDF file is in vertical format. See: votes_1-2.pdf
-
The signature PDF file should always be horizontal.
-
Could we get rid of the modal that appears when clicking on "Export signatures"? It seems that you are deleting something, but that's not the case for the action of exporting signatures.
-
[ ]
Fixed both items! Updated staging :) |
alecslupu
left a comment
There was a problem hiding this comment.
Codewise looks ok, I am waiting @NilHomedes's input to move forward.
NilHomedes
left a comment
There was a problem hiding this comment.
Thanks @mllocs now looks good to me! 💯
* develop: (27 commits) WCAG navigation submenu (#13796) Update gem dependencies (part 3) (#13849) Prevent notifications for deleted users (#13812) Retries NPM installation a couple times to prevent network timeouts (#13831) Update gem dependencies (part 2) (#13839) Enhance signature pdf export (#13778) Fix HexaPDF dependency (#13834) Fix flaky spec in authentication (#13827) Merge upload field for documents and image on proposal admin form (#13735) Update gem dependencies (#13835) Upgrade erb_lint to 0.8.0 (#13833) Fix flaky spec in geocoder (#13820) Refactor modules mounting routes (#13294) Upgrade check-spelling action (#13825) Add missing images in the custom registration emails from meetings (#13632) Add missing translations (#13793) Fix proposal map performance with hundreds of markers (#13798) Create multiple surveys within same Survey component (#13420) Accountability bulk actions (#13730) Improve UI for sorting options on comments (#13670) ...
🎩 What? Why?
Improve the format of the PDF export of the initiatives votes signatures to make it more useful.
📌 Related Issues
Testing
📷 Screenshots