Prevent notifications for deleted users#13812
Merged
andreslucena merged 5 commits intodecidim:developfrom Jan 14, 2025
Merged
Conversation
andreslucena
approved these changes
Jan 14, 2025
entantoencuanto
added a commit
that referenced
this pull request
Jan 14, 2025
* develop: (27 commits) WCAG navigation submenu (#13796) Update gem dependencies (part 3) (#13849) Prevent notifications for deleted users (#13812) Retries NPM installation a couple times to prevent network timeouts (#13831) Update gem dependencies (part 2) (#13839) Enhance signature pdf export (#13778) Fix HexaPDF dependency (#13834) Fix flaky spec in authentication (#13827) Merge upload field for documents and image on proposal admin form (#13735) Update gem dependencies (#13835) Upgrade erb_lint to 0.8.0 (#13833) Fix flaky spec in geocoder (#13820) Refactor modules mounting routes (#13294) Upgrade check-spelling action (#13825) Add missing images in the custom registration emails from meetings (#13632) Add missing translations (#13793) Fix proposal map performance with hundreds of markers (#13798) Create multiple surveys within same Survey component (#13420) Accountability bulk actions (#13730) Improve UI for sorting options on comments (#13670) ...
rsdeus
pushed a commit
to octree-gva/decidim
that referenced
this pull request
Jan 15, 2025
* Fix notifications_sending_frequency for deleted users * Add deleted check in email_notification_generator * Fix rubocop errors
This was referenced Feb 3, 2025
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
* Fix notifications_sending_frequency for deleted users * Add deleted check in email_notification_generator * Fix rubocop errors
andreslucena
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Fix notifications_sending_frequency for deleted users * Add deleted check in email_notification_generator * Fix rubocop errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While reviewing #13689, @andreslucena requested that notifications_sending_frequency should be set to "none" also for deleted users.
📌 Related Issues
Link your PR to an issue
Testing