Conversation
6ef3d69 to
f57add7
Compare
Member
Author
|
I think I solved this one 🥳 Mind that the first failures are actually related to a flaky in "[CI] Core - System", that fails a lot too. I'm trying to kill that one in #13827 This can be reviewed |
alecslupu
approved these changes
Jan 10, 2025
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
LGTM.
I remember trying to fix this locally, and had issues reproducing it. Will test directly in CI.
Contributor
|
@andreslucena , i am not 100% we should backport this, so i will merge only against develop ( not adding labels ) |
This was referenced Jan 13, 2025
entantoencuanto
added a commit
that referenced
this pull request
Jan 14, 2025
* develop: (27 commits) WCAG navigation submenu (#13796) Update gem dependencies (part 3) (#13849) Prevent notifications for deleted users (#13812) Retries NPM installation a couple times to prevent network timeouts (#13831) Update gem dependencies (part 2) (#13839) Enhance signature pdf export (#13778) Fix HexaPDF dependency (#13834) Fix flaky spec in authentication (#13827) Merge upload field for documents and image on proposal admin form (#13735) Update gem dependencies (#13835) Upgrade erb_lint to 0.8.0 (#13833) Fix flaky spec in geocoder (#13820) Refactor modules mounting routes (#13294) Upgrade check-spelling action (#13825) Add missing images in the custom registration emails from meetings (#13632) Add missing translations (#13793) Fix proposal map performance with hundreds of markers (#13798) Create multiple surveys within same Survey component (#13420) Accountability bulk actions (#13730) Improve UI for sorting options on comments (#13670) ...
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
andreslucena
added a commit
that referenced
this pull request
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎩 What? Why?
Lately we've seen some flaky related to Geocoding happen a lot in CI.
This is the stacktrace:
I'm not able to reproduce this locally, but I think the problem lies in the User-Agent, where it's looking for the string "Ruby" and finding other string ("Decidim/XXX"). This PR tries to fix this flaky by relaxing this check.A new theory! I think the problem lies in another file, as we're resetting the Geocoder mocks, and that makes that this other stub is disabled. Let's see what the CI says 🤞🏽
📌 Related Issues
Testing
As it is a flaky that can't be reproduced locally (or at least I can't do it), I'll re-run the relevant job ("[CI] Core - Libs") at least 5 times to see if it happens again.